From: Ben Widawsky Subject: [PATCH 2/3] drm/i915: Change uevent for reset completion Date: Thu, 18 Jul 2013 22:42:49 -0700 Message-ID: <1374212570-7330-2-git-send-email-ben@bwidawsk.net> References: <1374018073-6596-1-git-send-email-ben@bwidawsk.net> <1374212570-7330-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (unknown [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D9FCE5CCC for ; Thu, 18 Jul 2013 22:43:03 -0700 (PDT) In-Reply-To: <1374212570-7330-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel GFX Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org Prior to this patch, we used ERROR=0 as a way of signifying the reset was complete. The functionality dates back quite a ways to: commit f316a42cc49eca73b33d85feb6177e32431747ff Author: Ben Gamari Date: Mon Sep 14 17:48:46 2009 -0400 drm/i915: Hookup chip reset in error handler I'm not really sure what the motivation for this was originally, but to me it makes more sense to have a distinct event for error detection, and another event for reset start/finish (since reset is prone to failure). Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 9fe430a..03071d7 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c @@ -1436,7 +1436,7 @@ static void i915_error_work_func(struct work_struct *work) struct drm_device *dev = dev_priv->dev; struct intel_ring_buffer *ring; char *reset_event[] = { "RESET=1", NULL }; - char *reset_done_event[] = { "ERROR=0", NULL }; + char *reset_done_event[] = { "RESET=0", NULL }; int i, ret; /* -- 1.8.3.3