From: Fabio Estevam Subject: [PATCH 1/2] ASoC: fsl_spdif: Remove unnecessary dev_set_drvdata() Date: Fri, 23 Aug 2013 18:08:57 -0300 Message-ID: <1377292138-6884-1-git-send-email-festevam@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yh0-f52.google.com (mail-yh0-f52.google.com [209.85.213.52]) by alsa0.perex.cz (Postfix) with ESMTP id C08472610CB for ; Fri, 23 Aug 2013 23:09:53 +0200 (CEST) Received: by mail-yh0-f52.google.com with SMTP id f11so354603yha.39 for ; Fri, 23 Aug 2013 14:09:53 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: broonie@kernel.org Cc: Fabio Estevam , alsa-devel@alsa-project.org, b42378@freescale.com List-Id: alsa-devel@alsa-project.org From: Fabio Estevam Driver core clears the driver data to NULL after device_release or on probe failure, so just remove it. Signed-off-by: Fabio Estevam --- sound/soc/fsl/fsl_spdif.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index 42a4382..bf58086 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -1184,7 +1184,7 @@ static int fsl_spdif_probe(struct platform_device *pdev) &spdif_priv->cpu_dai_drv, 1); if (ret) { dev_err(&pdev->dev, "failed to register DAI: %d\n", ret); - goto error_dev; + return ret; } ret = imx_pcm_dma_init(pdev); @@ -1197,8 +1197,6 @@ static int fsl_spdif_probe(struct platform_device *pdev) error_component: snd_soc_unregister_component(&pdev->dev); -error_dev: - dev_set_drvdata(&pdev->dev, NULL); return ret; } -- 1.8.1.2