Received: from eggs.gnu.org ([2001:4830:134:3::10]:53935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGWH4-0000lp-6b for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:42:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGWGx-0005zS-C1 for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:42:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGWGx-0005zA-2R for qemu-devel@nongnu.org; Mon, 02 Sep 2013 11:42:35 -0400 Message-ID: <1378136553.2640.34.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Mon, 02 Sep 2013 18:42:33 +0300 In-Reply-To: References: <1378131189-25538-1-git-send-email-marcel.a@redhat.com> <1378131189-25538-4-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 3/3] hw/pci-host: catch acesses to unassigned pci addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Anthony Liguori , QEMU Developers , Andreas =?ISO-8859-1?Q?F=E4rber?= , "Michael S. Tsirkin" On Mon, 2013-09-02 at 15:39 +0100, Peter Maydell wrote: > On 2 September 2013 15:13, Marcel Apfelbaum wrote: > > Added a memory region that has negative priority and > > extends over all the pci adddress space. This region will > > "catch" all the accesses to the unassigned pci > > addresses and it will be possible to emulate the > > master abort scenario (When no device on the bus claims > > the transaction). > > > > Signed-off-by: Marcel Apfelbaum > > --- > > hw/pci-host/piix.c | 8 ++++++++ > > hw/pci-host/q35.c | 19 ++++++++++++++++--- > > include/hw/pci-host/q35.h | 1 + > > This is happening at the wrong layer -- you want this memory > region to be created and managed in the PCI core code so that > we get correct PCI-spec behaviour for all our PCI controllers, > not just the two x86 ones you've changed here.pci_address_space I saw that the memory regions are part of the Host state and duplicated for each host type(like pci_address_space). Question, why are not pci_address_space and pci_hole present in a core layer? I followed the existing code; from what you are saying I understand that also the existing memory regions like the one mentioned above should be moved in the core layer, right? Marcel > > -- PMM >