Received: from eggs.gnu.org ([2001:4830:134:3::10]:58887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGk6F-0007w5-Os for qemu-devel@nongnu.org; Tue, 03 Sep 2013 02:28:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VGk6A-0006kI-PY for qemu-devel@nongnu.org; Tue, 03 Sep 2013 02:28:27 -0400 Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:34490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VGk6A-0006k5-IA for qemu-devel@nongnu.org; Tue, 03 Sep 2013 02:28:22 -0400 From: Aurelien Jarno Date: Tue, 3 Sep 2013 08:27:59 +0200 Message-Id: <1378189680-11987-4-git-send-email-aurelien@aurel32.net> In-Reply-To: <1378189680-11987-1-git-send-email-aurelien@aurel32.net> References: <1378189680-11987-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH 3/4] tcg/optimize: improve known-zero bits for 32-bit ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Aurelien Jarno , Richard Henderson The shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values. Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0ed8983..b1f736b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -791,6 +791,12 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr, break; } + /* 32-bit ops (non 64-bit ops and non load/store ops) generate 32-bit + results */ + if (!(tcg_op_defs[op].flags & (TCG_OPF_CALL_CLOBBER | TCG_OPF_64BIT))) { + mask &= 0xffffffffu; + } + if (mask == 0) { assert(def->nb_oargs == 1); s->gen_opc_buf[op_index] = op_to_movi(op); -- 1.7.10.4