Received: from eggs.gnu.org ([2001:4830:134:3::10]:49130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJEXd-0001WL-BC for qemu-devel@nongnu.org; Mon, 09 Sep 2013 23:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJEXX-0007hX-L9 for qemu-devel@nongnu.org; Mon, 09 Sep 2013 23:23:01 -0400 Received: from mail-ob0-x22c.google.com ([2607:f8b0:4003:c01::22c]:62749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJEXX-0007hS-FE for qemu-devel@nongnu.org; Mon, 09 Sep 2013 23:22:55 -0400 Received: by mail-ob0-f172.google.com with SMTP id er7so6761501obc.3 for ; Mon, 09 Sep 2013 20:22:54 -0700 (PDT) Sender: Bo Yang From: Bo Yang Date: Tue, 10 Sep 2013 11:24:25 +0800 Message-Id: <1378783465-31216-1-git-send-email-boyang@suse.com> Subject: [Qemu-devel] [PATCH vgabios] Make windows8 work with high resolution when using -vga std in qmeu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann This patch has been sent to upstream vgabios maillist, but there is no response. Since it is useful for windows8 resolution, I resend it to qemu maillist for review. Signed-off-by: Bo Yang --- vbe.c | 42 ++++++++++++++++++++++++++++++++++++++---- 1 files changed, 38 insertions(+), 4 deletions(-) diff --git a/vbe.c b/vbe.c index 1fab2f9..eb9150c 100644 --- a/vbe.c +++ b/vbe.c @@ -754,6 +754,29 @@ lmulul: ret ASM_END +ASM_START +_size64: + push bp + mov bp, sp + push dx + +; multiply bbp by yres first as results fit in 16bits +; then multiply by xres + mov ax, 8[bp] + mul word 6[bp] + mul word 4[bp] +; divide by 2^19 ceiling result + add ax, #0xffff + adc dx, #7 + mov ax, dx + shr ax, #3 + + pop dx + pop bp + ret +ASM_END + + /** Function 00h - Return VBE Controller Information * * Input: @@ -857,7 +880,7 @@ Bit16u *AX;Bit16u ES;Bit16u DI; do { - size_64k = (Bit16u)((Bit32u)cur_info->info.XResolution * cur_info->info.XResolution * cur_info->info.BitsPerPixel) >> 19; + Bit16u size_64k = size64(cur_info->info.XResolution, cur_info->info.YResolution, cur_info->info.BitsPerPixel); if ((cur_info->info.XResolution <= dispi_get_max_xres()) && (cur_info->info.BitsPerPixel <= dispi_get_max_bpp()) && @@ -917,14 +940,25 @@ Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI; if (cur_info != 0) { + Bit16u max_bpp = dispi_get_max_bpp(); + Bit16u size_64k; + Bit16u totalMemory; + + outw(VBE_DISPI_IOPORT_INDEX, VBE_DISPI_INDEX_VIDEO_MEMORY_64K); + totalMemory = inw(VBE_DISPI_IOPORT_DATA); #ifdef DEBUG printf("VBE found mode %x\n",CX); #endif memsetb(ss, &info, 0, sizeof(ModeInfoBlock)); memcpyb(ss, &info, 0xc000, &(cur_info->info), sizeof(ModeInfoBlockCompact)); - if (using_lfb) { - info.NumberOfBanks = 1; - } + size_64k = size64(info.XResolution, info.YResolution, info.BitsPerPixel); + if ((info.XResolution > dispi_get_max_xres()) || + (info.BitsPerPixel > max_bpp) || + (size_64k > totalMemory)) + info.ModeAttributes &= ~VBE_MODE_ATTRIBUTE_SUPPORTED; + + /* Windows 8 require this to be 1! */ + info.NumberOfBanks = 1; #ifdef PCI_VID lfb_addr = pci_get_lfb_addr(PCI_VID); #else -- 1.6.0.2