From: Scott Wood Date: Tue, 10 Sep 2013 15:11:12 -0500 Subject: [U-Boot] [PATCH] mxs_nand: Fix ECC strength for NAND flash with OOB size of 224 In-Reply-To: <522F50A6.20105@denx.de> References: <1377355884-5920-1-git-send-email-eliedebrauwer@gmail.com> <522F50A6.20105@denx.de> Message-ID: <1378843872.12204.334.camel@snotra.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 2013-09-10 at 19:02 +0200, Stefano Babic wrote: > On 24/08/2013 16:51, Elie De Brauwer wrote: > > On a board with an i.mx28 and a Micron MT29F4G08ABAEAH4, Linux says: > > > > NAND device: Manufacturer ID: 0x2c, Chip ID: 0xdc (Micron MT29F4G08ABAEAH4), > > 512MiB, page size: 4096, OOB size: 224) the ECC strength is 16. > > > > root@(none):/sys/devices/virtual/mtd/mtd0# for i in ecc_strength oobsize subpagesize; do echo $i = `cat $i`; done > > ecc_strength = 16 > > oobsize = 224 > > subpagesize = 4096 > > > > The ECC strength was not properly discovered by U-Boot causing the data > > written by Linux to return an -74 (EBADMSG) when read from U-Boot. This > > patch fixes mxs_nand_get_ecc_strength() to function in case of a NAND > > flash with page_data_size = 4096 and page_oob_size= 224. > > > > Signed-off-by: Elie De Brauwer > > --- > > Scott, I found this is assigned to me in patchwork. Is it ok if I apply it ? > > Best regards, > Stefano Sure. Acked-by: Scott Wood I'm curious who's been doing these patchwork assignments and what they're basing it on. -Scott