From: Ian Campbell Subject: Re: [PATCH v2] xen: arm: improve VMID allocation. Date: Sat, 21 Sep 2013 17:02:20 +0100 Message-ID: <1379779340.8994.76.camel@hastur.hellion.org.uk> References: <1379433388-18850-1-git-send-email-ian.campbell@citrix.com> <5238874F.5030206@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5238874F.5030206@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2013-09-17 at 17:46 +0100, Julien Grall wrote: > On 09/17/2013 04:56 PM, Ian Campbell wrote: > > The VMID field is 8 bits. Rather than allowing only up to 256 VMs per host > > reboot before things start "acting strange" instead maintain a simple bitmap > > of used VMIDs and allocate them statically to guests upon creation. > > > > This limits us to 256 concurrent VMs which is a reasonable improvement. > > Eventually we will want a proper scheme to allocate VMIDs on context switch. > > > > The existing code reserves VMID==0, IIRC I thought this was "hypervisor > > context". Re-reading the ARM ARM I'm not spotting the bit which made me think > > this. However I haven't changed this behaviour here. > > > > Signed-off-by: Ian Campbell > Acked-by: Julien Grall Thanks, applied. I dropped the final paragraph of the changelog (The existing code reserves...) since I think we decided it was true...