Received: from multi.imgtec.com ([194.200.65.239]:55074 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6816841Ab3IZJfrAeEof (ORCPT ); Thu, 26 Sep 2013 11:35:47 +0200 From: Markos Chandras Subject: [PATCH] MIPS: kernel: traps: Remove useless BUG_ON() Date: Thu, 26 Sep 2013 10:35:31 +0100 Message-ID: <1380188131-28792-1-git-send-email-markos.chandras@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: linux-mips@linux-mips.org Cc: Markos Chandras Message-ID: <20130926093531.UHwdVaixqbCH5oAZEPEJdhWjXA_RzfiahOmgfisuGlU@z> Checking for n<0 && n>9 makes no sense because it can never be true. Moreover, we can have up to 64 vectored interrupts so BUG_ON(n>9) was wrong anyway. Signed-off-by: Markos Chandras Acked-by: Steven J. Hill --- This patch is for the upstream-sfr/mips-for-linux-next tree --- arch/mips/kernel/traps.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c index 524841f..f2ae9cb 100644 --- a/arch/mips/kernel/traps.c +++ b/arch/mips/kernel/traps.c @@ -1554,7 +1554,6 @@ static void *set_vi_srs_handler(int n, vi_handler_t addr, int srs) unsigned char *b; BUG_ON(!cpu_has_veic && !cpu_has_vint); - BUG_ON((n < 0) && (n > 9)); if (addr == NULL) { handler = (unsigned long) do_default_vi; -- 1.8.3.2