Received: from eggs.gnu.org ([2001:4830:134:3::10]:39019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPMF8-0001Nq-SQ for qemu-devel@nongnu.org; Thu, 26 Sep 2013 20:49:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPMEv-0004kF-1X for qemu-devel@nongnu.org; Thu, 26 Sep 2013 20:49:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52667 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPMEu-0004iU-Lk for qemu-devel@nongnu.org; Thu, 26 Sep 2013 20:49:00 -0400 From: Alexander Graf Date: Fri, 27 Sep 2013 02:48:15 +0200 Message-Id: <1380242934-20953-22-git-send-email-agraf@suse.de> In-Reply-To: <1380242934-20953-1-git-send-email-agraf@suse.de> References: <1380242934-20953-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 21/60] AArch64: Convert SIMD load/store to common function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Michael Matz , C Fontana , Dirk Mueller , Laurent Desnogues , Christoffer Dall , Richard Henderson We currently dulplicate load/store logic for simd operations throughout the place. Fortunately they follow a pretty clear pattern, so let's create common code to handle them. Signed-off-by: Alexander Graf --- target-arm/translate-a64.c | 99 ++++++++++++++++++++-------------------------- 1 file changed, 42 insertions(+), 57 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index f054488..ad20892 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -833,6 +833,42 @@ static void handle_simdldstm(DisasContext *s, uint32_t insn, bool is_wback) tcg_temp_free_i64(tcg_addr); } +static void simd_ld(TCGv_i64 tcg_reg, int freg_offs, int size) +{ + switch (size) { + case 0: + tcg_gen_ld8u_i64(tcg_reg, cpu_env, freg_offs); + break; + case 1: + tcg_gen_ld16u_i64(tcg_reg, cpu_env, freg_offs); + break; + case 2: + tcg_gen_ld32u_i64(tcg_reg, cpu_env, freg_offs); + break; + case 3: + tcg_gen_ld_i64(tcg_reg, cpu_env, freg_offs); + break; + } +} + +static void simd_st(TCGv_i64 tcg_reg, int freg_offs, int size) +{ + switch (size) { + case 0: + tcg_gen_st8_i64(tcg_reg, cpu_env, freg_offs); + break; + case 1: + tcg_gen_st16_i64(tcg_reg, cpu_env, freg_offs); + break; + case 2: + tcg_gen_st32_i64(tcg_reg, cpu_env, freg_offs); + break; + case 3: + tcg_gen_st_i64(tcg_reg, cpu_env, freg_offs); + break; + } +} + static void handle_dupg(DisasContext *s, uint32_t insn) { int rd = get_bits(insn, 0, 5); @@ -856,27 +892,8 @@ static void handle_dupg(DisasContext *s, uint32_t insn) } clear_fpreg(rd); - switch (size) { - case 0: - for (i = 0; i < (q ? 16 : 8); i++) { - tcg_gen_st8_i64(cpu_reg(rn), cpu_env, freg_offs_d + i); - } - break; - case 1: - for (i = 0; i < (q ? 16 : 8); i+=2) { - tcg_gen_st16_i64(cpu_reg(rn), cpu_env, freg_offs_d + i); - } - break; - case 2: - for (i = 0; i < (q ? 16 : 8); i+=4) { - tcg_gen_st32_i64(cpu_reg(rn), cpu_env, freg_offs_d + i); - } - break; - case 3: - for (i = 0; i < (q ? 16 : 8); i+=8) { - tcg_gen_st_i64(cpu_reg(rn), cpu_env, freg_offs_d + i); - } - break; + for (i = 0; i < (q ? 16 : 8); i += (1 << size)) { + simd_st(cpu_reg(rn), freg_offs_d + i, size); } } @@ -902,24 +919,8 @@ static void handle_umov(DisasContext *s, uint32_t insn) unallocated_encoding(s); } - switch (size) { - case 0: - idx = get_bits(imm5, 1, 4) << 0; - tcg_gen_ld8u_i64(cpu_reg(rd), cpu_env, freg_offs_n + idx); - break; - case 1: - idx = get_bits(imm5, 2, 3) << 1; - tcg_gen_ld16u_i64(cpu_reg(rd), cpu_env, freg_offs_n + idx); - break; - case 2: - idx = get_bits(imm5, 3, 2) << 2; - tcg_gen_ld32u_i64(cpu_reg(rd), cpu_env, freg_offs_n + idx); - break; - case 3: - idx = get_bits(imm5, 4, 1) << 3; - tcg_gen_ld_i64(cpu_reg(rd), cpu_env, freg_offs_n + idx); - break; - } + idx = get_bits(imm5, 1 + size, 4 - size) << size; + simd_ld(cpu_reg(rd), freg_offs_n + idx, size); } static void handle_insg(DisasContext *s, uint32_t insn) @@ -938,24 +939,8 @@ static void handle_insg(DisasContext *s, uint32_t insn) } } - switch (size) { - case 0: - idx = get_bits(imm5, 1, 4) << 0; - tcg_gen_st8_i64(cpu_reg(rn), cpu_env, freg_offs_d + idx); - break; - case 1: - idx = get_bits(imm5, 2, 3) << 1; - tcg_gen_st16_i64(cpu_reg(rn), cpu_env, freg_offs_d + idx); - break; - case 2: - idx = get_bits(imm5, 3, 2) << 2; - tcg_gen_st32_i64(cpu_reg(rn), cpu_env, freg_offs_d + idx); - break; - case 3: - idx = get_bits(imm5, 4, 1) << 3; - tcg_gen_st_i64(cpu_reg(rn), cpu_env, freg_offs_d + idx); - break; - } + idx = get_bits(imm5, 1 + size, 4 - size) << size; + simd_st(cpu_reg(rn), freg_offs_d + idx, size); } /* SIMD ORR */ -- 1.7.12.4