Received: from eggs.gnu.org ([2001:4830:134:3::10]:57383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZHrp-0003hU-CF for qemu-devel@nongnu.org; Thu, 24 Oct 2013 06:10:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZHrj-0006aI-As for qemu-devel@nongnu.org; Thu, 24 Oct 2013 06:10:13 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:51181 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZHri-0006ZI-Vx for qemu-devel@nongnu.org; Thu, 24 Oct 2013 06:10:07 -0400 From: Peter Lieven Date: Thu, 24 Oct 2013 12:07:06 +0200 Message-Id: <1382609227-23989-18-git-send-email-pl@kamp.de> In-Reply-To: <1382609227-23989-1-git-send-email-pl@kamp.de> References: <1382609227-23989-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv7 17/17] qemu-img: conditionally zero out target on convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, Peter Lieven , ronniesahlberg@gmail.com, pbonzini@redhat.com If the target has_zero_init = 0, but supports efficiently writing zeroes by unmapping we call bdrv_make_zero to avoid fully allocating the target. This currently works only for iscsi. It can be extended to raw with BLKDISCARDZEROES for example. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- qemu-img.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 7f08364..bec6da3 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1355,7 +1355,7 @@ static int img_convert(int argc, char **argv) } } - flags = BDRV_O_RDWR; + flags = min_sparse ? (BDRV_O_RDWR | BDRV_O_UNMAP) : BDRV_O_RDWR; ret = bdrv_parse_cache_flags(cache, &flags); if (ret < 0) { error_report("Invalid cache option: %s", cache); @@ -1471,6 +1471,14 @@ static int img_convert(int argc, char **argv) } else { int has_zero_init = min_sparse ? bdrv_has_zero_init(out_bs) : 0; + if (!has_zero_init && bdrv_can_write_zeroes_with_unmap(out_bs)) { + ret = bdrv_make_zero(out_bs, BDRV_REQ_MAY_UNMAP); + if (ret < 0) { + goto out; + } + has_zero_init = 1; + } + sector_num = 0; // total number of sectors converted so far nb_sectors = total_sectors - sector_num; if (nb_sectors != 0) { -- 1.7.9.5