Received: from eggs.gnu.org ([2001:4830:134:3::10]:47210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbBqJ-0000In-KH for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbBqD-0002Cy-PD for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:08:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbBqD-0002CU-Gt for qemu-devel@nongnu.org; Tue, 29 Oct 2013 12:08:25 -0400 From: armbru@redhat.com Date: Tue, 29 Oct 2013 17:08:10 +0100 Message-Id: <1383062897-30084-4-git-send-email-armbru@redhat.com> In-Reply-To: <1383062897-30084-1-git-send-email-armbru@redhat.com> References: <1383062897-30084-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 03/10] cpu: Document why cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, borntraeger@de.ibm.com, afaerber@suse.de, anthony@codemonkey.ws, peter.maydell@linaro.org From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell --- qom/cpu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 09c15e6..6e0d54e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass, void *data) k->gdb_read_register = cpu_common_gdb_read_register; k->gdb_write_register = cpu_common_gdb_write_register; dc->realize = cpu_common_realizefn; - dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */ + /* + * Reason: CPUs still need special care by board code: wiring up + * IRQs, adding reset handlers, halting non-first CPUS, ... + */ + dc->cannot_instantiate_with_device_add_yet = true; } static const TypeInfo cpu_type_info = { -- 1.8.1.4