From: Ian Campbell Subject: Re: [PATCH 1 of 5 V3] remus: add libnl3 dependency to autoconf scripts Date: Thu, 31 Oct 2013 20:13:00 +0000 Message-ID: <1383250380.5436.116.camel@dagon.hellion.org.uk> References: <357655a1598cba8f8460.1382335083@athos.nss.cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <357655a1598cba8f8460.1382335083@athos.nss.cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shriram Rajagopalan Cc: Andrew Cooper , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sun, 2013-10-20 at 22:58 -0700, Shriram Rajagopalan wrote: > diff -r 808aba98084e -r 357655a1598c tools/configure.ac > --- a/tools/configure.ac Fri Oct 11 18:16:11 2013 -0700 > +++ b/tools/configure.ac Fri Oct 11 18:16:21 2013 -0700 > @@ -219,6 +219,24 @@ AC_SUBST(libiconv) > # Checks for header files. > AC_CHECK_HEADERS([yajl/yajl_version.h sys/eventfd.h]) > > +# Check for libnl3 >=3.2.8. If present enable remus network buffering. > +PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.2.8 libnl-route-3.0 >= 3.2.8], > + [libnl3_lib="y"], [libnl3_lib="n"]) > + > +# Check for libnl3 command line utilities These cli utils are needed on the runtime host but not the build host, right? (for the benefit of the hotplug scripts I suppose?) This check only runs on the build host, so it will fail needlessly if the tools aren't there while at the same time not catching the case where they are missing from the runtime host. Best bet is to omit this check and simply list them in the README, in the list of optional tools (and reference tools/remus/README for more info if you like). Ian.