From: Ian Campbell Subject: Re: [PATCH 5 of 5 V3] tools/xl: Remus - Network buffering cmdline switch Date: Thu, 31 Oct 2013 20:38:17 +0000 Message-ID: <1383251897.5436.131.camel@dagon.hellion.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shriram Rajagopalan Cc: Andrew Cooper , Stefano Stabellini , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Sun, 2013-10-20 at 22:58 -0700, Shriram Rajagopalan wrote: > diff -r a8deb9499e9d -r f4eea1e0ac3e docs/man/xl.pod.1 > --- a/docs/man/xl.pod.1 Sun Oct 20 11:59:06 2013 -0700 > +++ b/docs/man/xl.pod.1 Sun Oct 20 11:59:16 2013 -0700 > @@ -398,8 +398,7 @@ Print huge (!) amount of debug during th > Enable Remus HA for domain. By default B relies on ssh as a transport > mechanism between the two hosts. > > -N.B: Remus support in xl is still in experimental (proof-of-concept) phase. > - There is no support for network or disk buffering at the moment. > +N.B: There is no support for disk buffering at the moment. > > B > > @@ -418,6 +417,13 @@ Generally useful for debugging. > > Disable memory checkpoint compression. > > +=item B<-n> > + > +Enable network output buffering. The default script used to configure > +network buffering is /etc/xen/scripts/remus-netbuf-setup. If you wish to > +use a custom script, set the global variable "remus.default.netbufscript" > +in /etc/xen/xl.conf to point to your script. No docs for -N ? > @@ -7133,6 +7140,11 @@ int main_remus(int argc, char **argv) > domid = find_domain(argv[optind]); > host = argv[optind + 1]; > > + if (r_info.netbuf && !r_info.netbufscript) { Will the code do anything if netbuf==False but netbufscript!=NULL? > + if (default_remus_netbufscript) This if is redundant isn't it, it just avoids assigning NULL to a variable which is already NULL. Given the above two comments this whole block could be if (!r_info.netbufscript) r_info.netbufscript = default... [...] > - fprintf(stderr, "remus sender: libxl_domain_suspend failed" > - " (rc=%d)\n", rc); Was this removed on purpose? It seemed useful looking and wasn't mentioned in the commit message. Ian.