From: Ian Campbell Subject: Re: [PATCH 5 of 5 V3] tools/xl: Remus - Network buffering cmdline switch Date: Thu, 31 Oct 2013 22:29:46 +0000 Message-ID: <1383258586.5436.171.camel@dagon.hellion.org.uk> References: <1383251897.5436.131.camel@dagon.hellion.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: rshriram@cs.ubc.ca Cc: Andrew Cooper , Stefano Stabellini , Ian Jackson , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2013-10-31 at 14:47 -0700, Shriram Rajagopalan wrote: > > Yes, because the error message was not representative. That code block > currently looks like this (after removing the fprintf), which is bit > more informative. Makes sense, thanks. > > > /* If we are here, it means remus setup/domain suspend/backup has > > > > * failed. Try to resume the domain and exit gracefully. > > > > * TODO: Split-Brain check. > > > > */ > if (rc == ERROR_GUEST_TIMEDOUT) > fprintf(stderr, "Failed to suspend domain at primary.\n"); > else { > fprintf(stderr, "Remus: Backup failed? resuming domain at > primary.\n"); > libxl_domain_resume(ctx, domid, 1, 0); > } > > > > Ian. > > > > >