From: Scott Wood Date: Tue, 5 Nov 2013 19:38:53 -0600 Subject: [U-Boot] [PATCH 4/6][v2] Makefile:Add u-boot-with-spl-pbl.bin target for SPL In-Reply-To: <1382675948-24849-1-git-send-email-prabhakar@freescale.com> References: <1382675948-24849-1-git-send-email-prabhakar@freescale.com> Message-ID: <1383701933.25829.125.camel@snotra.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2013-10-25 at 10:09 +0530, Prabhakar Kushwaha wrote: > +ifdef CONFIG_PBLPBI_CONFIG > +ALL-y += $(obj)$(SPL_BIN).pbl > +endif I realize this symbol has already been introduced, but it's not documented and would be better called something like CONFIG_SYS_FSL_PBL_PBI (and likewise CONFIG_SYS_FSL_PBL_RCW). > all: $(ALL-y) > > ifdef CONFIG_SAMSUNG > @@ -192,6 +196,11 @@ endif > $(obj)$(SPL_BIN).bin: $(obj)$(SPL_BIN) > $(OBJCOPY) $(OBJCFLAGS) -O binary $< $@ > > +$(obj)$(SPL_BIN).pbl: $(obj)$(SPL_BIN).bin > + $(obj)../tools/mkimage -n $(CONFIG_PBLRCW_CONFIG) \ > + -R $(CONFIG_PBLPBI_CONFIG) -T pblimage \ > + -d $< $@ This could be moved to rules.mk as a pattern rule for turning any .bin into .pbl (and thus avoid duplication between spl and the main makefile). -Scott