Received: from eggs.gnu.org ([2001:4830:134:3::10]:41912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdtVP-000676-SA for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:10:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdtVH-00035i-B3 for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:10:07 -0500 Received: from mail-oa0-x22f.google.com ([2607:f8b0:4003:c02::22f]:39504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdtVH-00035e-6H for qemu-devel@nongnu.org; Tue, 05 Nov 2013 22:09:59 -0500 Received: by mail-oa0-f47.google.com with SMTP id k1so1572012oag.34 for ; Tue, 05 Nov 2013 19:09:58 -0800 (PST) From: Xu Wang Date: Tue, 5 Nov 2013 22:09:18 -0500 Message-Id: <1383707361-19580-3-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1383707361-19580-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V6 2/5] qemu-img: Add infinite loop checking in bdrv_new_open() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, Xu Wang , wdongxu@linux.vnet.ibm.com, xiawenc@linux.vnet.ibm.com Every image should be checked if there is infinite loop in backing file chain before open it. So infinite loop check was added into bdrv_new_open(). If @filename is opened without the flag BDRV_O_NO_BACKING, the infinite loop check should be called. Signed-off-by: Xu Wang --- qemu-img.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index d5ec45b..3af7996 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -281,6 +281,14 @@ static BlockDriverState *bdrv_new_open(const char *filename, drv = NULL; } + /* check backing file loop if the whole chain need to be opened */ + if (!(flags & BDRV_O_NO_BACKING) && + !bdrv_backing_chain_okay(filename, fmt)) { + error_report("bdrv_new_open: Open %s failed. There is loop exists " + "in the backing chain", filename); + goto fail; + } + ret = bdrv_open(bs, filename, NULL, flags, drv, &local_err); if (ret < 0) { error_report("Could not open '%s': %s", filename, -- 1.8.1.4