From: Ian Campbell Subject: Re: [PATCH] libxl: save/restore errno in SIGCHLD handler Date: Mon, 11 Nov 2013 17:28:16 +0000 Message-ID: <1384190896.1883.7.camel@kazak.uk.xensource.com> References: <21121.4572.173166.215444@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21121.4572.173166.215444@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2013-11-11 at 17:20 +0000, Ian Jackson wrote: > Without this, code interrupted by SIGCHLD may experience strange > values of errno. (As far as I know this is not the cause of any > reported bugs.) > > This fix should be backported in due course. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell > --- > tools/libxl/libxl_fork.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/libxl/libxl_fork.c b/tools/libxl/libxl_fork.c > index 044ddad..b6f0b2d 100644 > --- a/tools/libxl/libxl_fork.c > +++ b/tools/libxl/libxl_fork.c > @@ -157,8 +157,10 @@ int libxl__carefd_fd(const libxl__carefd *cf) > > static void sigchld_handler(int signo) > { > + int esave = errno; > int e = libxl__self_pipe_wakeup(sigchld_owner->sigchld_selfpipe[1]); > assert(!e); /* errors are probably EBADF, very bad */ > + errno = esave; > } > > static void sigchld_removehandler_core(void)