Received: from eggs.gnu.org ([2001:4830:134:3::10]:50909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgQcH-0003F3-Pa for qemu-devel@nongnu.org; Tue, 12 Nov 2013 21:55:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgQc8-0008Nv-Tb for qemu-devel@nongnu.org; Tue, 12 Nov 2013 21:55:41 -0500 Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]:33268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgQNR-0007RE-Vb for qemu-devel@nongnu.org; Tue, 12 Nov 2013 21:40:22 -0500 Received: by mail-oa0-f51.google.com with SMTP id i4so4490152oah.38 for ; Tue, 12 Nov 2013 18:40:21 -0800 (PST) From: Xu Wang Date: Tue, 12 Nov 2013 21:39:39 -0500 Message-Id: <1384310380-9805-4-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1384310380-9805-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1384310380-9805-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V7 3/4] block: Add backing file loop check in change_backing_file() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, Xu Wang , wdongxu@linux.vnet.ibm.com, xiawenc@linux.vnet.ibm.com Backing file loop should be checked before calling change_backing_ file(). If loop appeared, this calling should be stopped and an error printed. Signed-off-by: Xu Wang --- block.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index c2ed6ef..861b133 100644 --- a/block.c +++ b/block.c @@ -2083,6 +2083,11 @@ int bdrv_change_backing_file(BlockDriverState *bs, return -EINVAL; } + /* Check if loop exists in backing files chain after change */ + if (!bdrv_backing_chain_okay(backing_file, backing_fmt, bs->filename)) { + return -EIO; + } + if (drv->bdrv_change_backing_file != NULL) { ret = drv->bdrv_change_backing_file(bs, backing_file, backing_fmt); } else { -- 1.8.1.4