From: Johannes Berg Subject: Re: [patch] ALSA: snd-aoa: two copy and paste bugs Date: Wed, 13 Nov 2013 09:29:54 +0100 Message-ID: <1384331394.14578.0.camel@jlt4.sipsolutions.net> References: <20131113074520.GD25541@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: Takashi Iwai Cc: Dan Carpenter , Jaroslav Kysela , Benjamin Herrenschmidt , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, 2013-11-13 at 09:29 +0100, Takashi Iwai wrote: > At Wed, 13 Nov 2013 10:45:20 +0300, > Dan Carpenter wrote: > > > > These functions were cut and paste and the tests for NULL weren't > > updated properly. > > > > Signed-off-by: Dan Carpenter > > Thanks, applied. FWIW, looks fine to me - I wonder how long this has been broken though, must be practically forever. I guess we never got it wrong and missed adding some pointers? :-) johannes