From: Ian Campbell Subject: Re: [PATCH v5 06/19] xen: arm: move dom0 gic and timer device tree nodes under /xen/ Date: Thu, 14 Nov 2013 08:18:04 +0000 Message-ID: <1384417084.7059.17.camel@dagon.hellion.org.uk> References: <1384366234.29080.8.camel@kazak.uk.xensource.com> <1384366285-29277-6-git-send-email-ian.campbell@citrix.com> <5283EFA5.7090401@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5283EFA5.7090401@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, 2013-11-13 at 21:31 +0000, Julien Grall wrote: > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 186746c..8645aa1 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -48,6 +48,24 @@ custom_param("dom0_mem", parse_dom0_mem); > > */ > > #define DOM0_FDT_EXTRA_SIZE (128 + sizeof(struct fdt_reserve_entry)) > > Don't we need to update DOM0_FDT_EXTRA_SIZE? Nothing is complaining about running out of space, so I guess the existing 128 slack remains sufficient. We don't actually add all that much -- most of what we add was previously removed (GIC, timer, memory nodes etc). Ian.