From: Scott Wood Date: Thu, 14 Nov 2013 15:27:58 -0600 Subject: [U-Boot] [U-Boot, v1, 1/4] mtd: nand: add NAND_BUSWIDTH_AUTO to autodetect bus width In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA37964@DBDE04.ent.ti.com> References: <1378819628-28745-2-git-send-email-pekon@ti.com> <20131114013727.GA12292@home.buserror.net> ,<20980858CB6D3A4BAE95CA194937D5E73EA37958@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73EA37964@DBDE04.ent.ti.com> Message-ID: <1384464478.1403.207.camel@snotra.buserror.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2013-11-14 at 04:32 +0000, Gupta, Pekon wrote: > > From: Scott Wood [mailto:scottwood at freescale.com] > > On Tue, Sep 10, 2013 at 06:57:05PM +0530, pekon gupta wrote: > > > From: Matthieu CASTET > > > > > > This patch is slightly modified from following linux patch > > > http://lists.infradead.org/pipermail/linux-mtd/2012- > > November/044803.html > > > > Which is now commit 64b37b2a63eb2f80b65c7185f0013f8ffc637ae3 > > > > > So retaining the authorship to Matthieu CASTET > > > > > *Modifications from original patch* > > > reset chip->read_byte, chip->read_buf, chip->write_buf before setting > > defaults. > > > > Why does U-Boot need this if Linux doesn't? > > > Yes, I plan to drop this patch. > Reason: Though this feature was introduced in linux long back, but hardly > any mtd/nand drivers using this. Also there are alternative approaches > which do not require any change in individual controller drivers, but just > in generic NAND driver. > I have proposed them in linux mtd-maillist, I'll propose same in my next > version of patch-set. > > http://lists.infradead.org/pipermail/linux-mtd/2013-November/049744.html Hmm, I don't like the "kill NAND_BUSWIDTH_AUTO" sentiment. The device tree is for describing things that can't be reasonably discovered through hardware interfaces. ONFI identification always being x8 seems designed specifically to allow said discovery. -Scott