Received: from eggs.gnu.org ([2001:4830:134:3::10]:46179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhD2f-0002A8-LD for qemu-devel@nongnu.org; Fri, 15 Nov 2013 01:38:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhD2X-00079R-4c for qemu-devel@nongnu.org; Fri, 15 Nov 2013 01:38:09 -0500 Received: from mail-oa0-x232.google.com ([2607:f8b0:4003:c02::232]:59731) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhD2W-00079M-Vy for qemu-devel@nongnu.org; Fri, 15 Nov 2013 01:38:01 -0500 Received: by mail-oa0-f50.google.com with SMTP id k1so3466554oag.23 for ; Thu, 14 Nov 2013 22:38:00 -0800 (PST) From: Xu Wang Date: Fri, 15 Nov 2013 01:37:23 -0500 Message-Id: <1384497443-17292-5-git-send-email-gesaint@linux.vnet.ibm.com> In-Reply-To: <1384497443-17292-1-git-send-email-gesaint@linux.vnet.ibm.com> References: <1384497443-17292-1-git-send-email-gesaint@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V8 4/4] blockdev: Add infinite loop check in drive_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, Xu Wang , wdongxu@linux.vnet.ibm.com, xiawenc@linux.vnet.ibm.com Check the backing file for a loop during image boot, to avoid a lack or response or segfault. Signed-off-by: Xu Wang --- blockdev.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/blockdev.c b/blockdev.c index b260477..60a3c93 100644 --- a/blockdev.c +++ b/blockdev.c @@ -510,6 +510,14 @@ static DriveInfo *blockdev_init(QDict *bs_opts, bdrv_flags |= ro ? 0 : BDRV_O_RDWR; + /* Add backing file loop check */ + if (!bdrv_backing_chain_okay(file, drv ? drv->format_name : NULL, + NULL, &error)) { + error_setg(errp, "drive_init: backing file loop check failed. %s", + error_get_pretty(error)); + goto err; + } + QINCREF(bs_opts); ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv, &error); -- 1.8.1.4