From: Thomas Hellstrom Subject: [PATCH] drm/vma-manager: Don't unmap COW'd pages when zapping bo ptes Date: Wed, 20 Nov 2013 01:55:49 -0800 Message-ID: <1384941349-3550-1-git-send-email-thellstrom@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTP id 52A46106828 for ; Wed, 20 Nov 2013 01:56:05 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: jakob@vmware.com, dh.herrmann@gmail.com, dri-devel@lists.freedesktop.org Cc: Thomas Hellstrom , linux-graphics-maintainer@vmware.com List-Id: dri-devel@lists.freedesktop.org Not sure if there are any user-space users of private bo mappings, but if there are, or will be, zapping the COW'd pages when, for example, moving a bo would confuse the user immensely since the net effect for the user would be that pages written to would lose their contents. Signed-off-by: Thomas Hellstrom --- include/drm/drm_vma_manager.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/drm/drm_vma_manager.h b/include/drm/drm_vma_manager.h index c18a593..347077d 100644 --- a/include/drm/drm_vma_manager.h +++ b/include/drm/drm_vma_manager.h @@ -231,9 +231,9 @@ static inline void drm_vma_node_unmap(struct drm_vma_offset_node *node, struct address_space *file_mapping) { if (file_mapping && drm_vma_node_has_offset(node)) - unmap_mapping_range(file_mapping, - drm_vma_node_offset_addr(node), - drm_vma_node_size(node) << PAGE_SHIFT, 1); + unmap_shared_mapping_range + (file_mapping, drm_vma_node_offset_addr(node), + drm_vma_node_size(node) << PAGE_SHIFT); } /** -- 1.7.10.4