Received: from eggs.gnu.org ([2001:4830:134:3::10]:40557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlESI-00078l-K8 for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlESC-0008Mp-Tp for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:14 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:35771 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlESC-0008MF-K3 for qemu-devel@nongnu.org; Tue, 26 Nov 2013 03:57:08 -0500 From: Peter Lieven Date: Tue, 26 Nov 2013 09:56:23 +0100 Message-Id: <1385456183-24840-10-git-send-email-pl@kamp.de> In-Reply-To: <1385456183-24840-1-git-send-email-pl@kamp.de> References: <1385456183-24840-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv2 1.8 9/9] qemu-img: increase min_sparse to 128 sectors (64kb) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , stefanha@redhat.com Suggested-by: Paolo Bonzini Signed-off-by: Peter Lieven --- qemu-img.c | 4 ++-- qemu-img.texi | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index cc7540f..6f1179b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -101,7 +101,7 @@ static void help(void) " '-p' show progress of command (only certain commands)\n" " '-pp' show progress of command in sectors (only convert command)\n" " '-q' use Quiet mode - do not print any output (except errors)\n" - " '-S' indicates the consecutive number of bytes (defaults to 4k) that must\n" + " '-S' indicates the consecutive number of bytes (defaults to 64k) that must\n" " contain only zeros for qemu-img to create a sparse image during\n" " conversion. If the number of bytes is 0, the source will not be scanned for\n" " unallocated or zero sectors, and the destination image will always be\n" @@ -1158,7 +1158,7 @@ static int img_convert(int argc, char **argv) QEMUOptionParameter *out_baseimg_param; char *options = NULL; const char *snapshot_name = NULL; - int min_sparse = 8; /* Need at least 4k of zeros for sparse detection */ + int min_sparse = 128; /* Need at least 64k of zeros for sparse detection */ bool quiet = false; Error *local_err = NULL; diff --git a/qemu-img.texi b/qemu-img.texi index cb4a3eb..c0e86ab 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -195,7 +195,7 @@ Image conversion is also useful to get smaller image when using a growable format such as @code{qcow} or @code{cow}: the empty sectors are detected and suppressed from the destination image. -@var{sparse_size} indicates the consecutive number of bytes (defaults to 4k) +@var{sparse_size} indicates the consecutive number of bytes (defaults to 64k) that must contain only zeros for qemu-img to create a sparse image during conversion. If @var{sparse_size} is 0, the source will not be scanned for unallocated or zero sectors, and the destination image will always be -- 1.7.9.5