From: Kuo-Jung Su Date: Thu, 28 Nov 2013 10:47:06 +0800 Subject: [U-Boot] [PATCH v2 4/4] cmd_eeprom: bug fix for i2c read/write In-Reply-To: <1385606826-2540-1-git-send-email-dantesu@gmail.com> References: <1385606826-2540-1-git-send-email-dantesu@gmail.com> Message-ID: <1385606826-2540-5-git-send-email-dantesu@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de From: Kuo-Jung Su The local pointer of address (i.e., addr) only gets referenced in SPI mode, and it won't be appropriate to pass only 1 bytes addr[1] to i2c_read/i2c_write while CONFIG_SYS_I2C_EEPROM_ADDR_LEN > 1. To avoid ambiguity, this patch would drop the use of address pointer in I2C mode, and directly pass (dev_addr, offset) to i2c_read/i2c_write. Signed-off-by: Kuo-Jung Su Cc: Alexey Brodkin Cc: Jean-Christophe PLAGNIOL-VILLARD cc: Peter Tyser Cc: Heiko Schocher Cc: Wolfgang Denk Cc: Stefan Roese Cc: Mischa Jonker --- Changes for v2: - Initial release common/cmd_eeprom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_eeprom.c b/common/cmd_eeprom.c index 02539c4..0edc259 100644 --- a/common/cmd_eeprom.c +++ b/common/cmd_eeprom.c @@ -161,7 +161,7 @@ int eeprom_read (unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cnt #if defined(CONFIG_SPI) && !defined(CONFIG_ENV_EEPROM_IS_ON_I2C) spi_read (addr, alen, buffer, len); #else - if (i2c_read (addr[0], addr[1], alen-1, buffer, len) != 0) + if (i2c_read (dev_addr, offset, alen-1, buffer, len) != 0) rcode = 1; #endif buffer += len; @@ -339,7 +339,7 @@ int eeprom_write (unsigned dev_addr, unsigned offset, uchar *buffer, unsigned cn /* Write is enabled ... now write eeprom value. */ #endif - if (i2c_write (addr[0], addr[1], alen-1, buffer, len) != 0) + if (i2c_write (dev_addr, offset, alen-1, buffer, len) != 0) rcode = 1; #endif -- 1.7.9.5