From: Mark Salter Subject: Re: [PATCH v2 00/11] Consolidate asm/fixmap.h files Date: Tue, 10 Dec 2013 10:49:56 -0500 Message-ID: <1386690596.1979.43.camel@deneb.redhat.com> References: <1385396045-15852-1-git-send-email-msalter@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jonas Bonn Cc: "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" List-Id: linux-arch.vger.kernel.org On Tue, 2013-12-10 at 09:48 +0100, Jonas Bonn wrote: > Hi Mark, > > Is there some reason you've excluded OpenRISC here? Did you just miss > it, or does the implementation diverage too much to be usable with > your generic version? It was the runtime BUG() in fix_to_virt() instead of the usual build time check. I thought that might be a toolchain issue and I didn't have a toolchain to try it with. If you're okay with the build time check, I don't see why you couldn't use the generic macros. --Mark