From: msalter@redhat.com (Mark Salter) Date: Tue, 10 Dec 2013 12:58:02 -0500 Subject: [PATCH 3/3] arm64: add EFI runtime services In-Reply-To: <20131209135158.GH24997@rocoto.smurfnet.nu> References: <1385762712-17043-1-git-send-email-msalter@redhat.com> <1385762712-17043-4-git-send-email-msalter@redhat.com> <20131209135158.GH24997@rocoto.smurfnet.nu> Message-ID: <1386698282.1979.44.camel@deneb.redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2013-12-09 at 14:52 +0100, Leif Lindholm wrote: > Apologies for late feedback. > > On Fri, Nov 29, 2013 at 05:05:12PM -0500, Mark Salter wrote: > > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c > > new file mode 100644 > > index 0000000..1bad8a7 > > --- /dev/null > > +++ b/arch/arm64/kernel/efi.c > > @@ -0,0 +1,507 @@ > > +/* > > + * Extensible Firmware Interface > > + * > > + * Based on Extensible Firmware Interface Specification version 2.3.1 > > Actually, for arm64, we're relying on UEFI 2.4 or later. You're right. > > > + * > > + * Copyright (C) 2013 Linaro Ltd. > > And I'd say you've easily done enough here to motivate adding Red Hat. > > > + * > > + * Adapted for arm64 from arch/arm/kernel/efi.c code > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#define efi_early_remap(a, b) \ > > + ((__force void *)early_ioremap((a), (b))) > > Do we not want early_memremap() here, rather than early_ioremap()? > Yes.