Received: from eggs.gnu.org ([2001:4830:134:3::10]:48565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5pO-00027T-P9 for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:57:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vr5pK-0002Yl-08 for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:57:18 -0500 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:52346 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vr5pJ-0002VB-JG for qemu-devel@nongnu.org; Thu, 12 Dec 2013 07:57:13 -0500 From: Peter Lieven Date: Thu, 12 Dec 2013 13:57:05 +0100 Message-Id: <1386853025-32337-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH] block: expect get_block_status errors in bdrv_make_zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, Peter Lieven , qemu-stable@nongnu.org, stefanha@redhat.com during testing around with 4k LUNs a bad target implementation triggert an -EIO in iscsi_get_block_status, but it got never caught resulting in an invinite loop. CC: qemu-stable@nongnu.org Signed-off-by: Peter Lieven --- block.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 13f001a..64e7d22 100644 --- a/block.c +++ b/block.c @@ -2421,6 +2421,11 @@ int bdrv_make_zero(BlockDriverState *bs, BdrvRequestFlags flags) nb_sectors = INT_MAX; } ret = bdrv_get_block_status(bs, sector_num, nb_sectors, &n); + if (ret < 0) { + error_report("error getting block status at sector %" PRId64 ": %s", + sector_num, strerror(-ret)); + return ret; + } if (ret & BDRV_BLOCK_ZERO) { sector_num += n; continue; -- 1.7.9.5