From: Rodrigo Vivi Subject: [PATCH 1/2] drm/i915: Only use read-back pipe config Date: Wed, 15 Jan 2014 17:07:29 -0200 Message-ID: <1389812850-4913-2-git-send-email-rodrigo.vivi@gmail.com> References: <1389812850-4913-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qe0-f42.google.com (mail-qe0-f42.google.com [209.85.128.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 4213110DC1C for ; Wed, 15 Jan 2014 11:07:47 -0800 (PST) Received: by mail-qe0-f42.google.com with SMTP id b4so1569177qen.1 for ; Wed, 15 Jan 2014 11:07:46 -0800 (PST) In-Reply-To: <1389812850-4913-1-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e77d4b8..5c6b148 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -9517,6 +9517,9 @@ check_crtc_state(struct drm_device *dev) intel_dump_pipe_config(crtc, &crtc->config, "[sw state]"); } + + /* Make sure our code only depends upon stuff we read back. */ + memcpy(&pipe_config, &crtc->config, sizeof(pipe_config)); } } -- 1.8.3.1