From: Alexey Brodkin Date: Mon, 10 Feb 2014 09:42:03 +0400 Subject: [U-Boot] [PATCH] env: disable CONFIG_ETHADDR & CONFIG_IPADDR Message-ID: <1392010923-3374-1-git-send-email-abrodkin@synopsys.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de We don't want to have duplicates of the same MAC or/and IP address within one network. But if those values are hard-coded into particular board config chances are high that multiple instances of the same board may easily have the same IP/MAC addresses. As for disabled options CONFIG_GATEWAYIP and CONFIG_NETMASK - they make no sense without CONFIG_IPADDR. If this change is acceptable on the next step whether as a separate follow-up patch or v2 re-spin I may do a clean-up of existing configs. Signed-off-by: Alexey Brodkin Cc: Wolfgang Denk Cc: Tom Rini Cc: Vineet Gupta --- include/env_default.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/env_default.h b/include/env_default.h index 90431be..c1dbaa3 100644 --- a/include/env_default.h +++ b/include/env_default.h @@ -50,28 +50,28 @@ const uchar default_environment[] = { "loads_echo=" __stringify(CONFIG_LOADS_ECHO) "\0" #endif #ifdef CONFIG_ETHADDR - "ethaddr=" __stringify(CONFIG_ETHADDR) "\0" +# error "Please DO NOT set CONFIG_ETHADDR in board configuration!" #endif #ifdef CONFIG_ETH1ADDR - "eth1addr=" __stringify(CONFIG_ETH1ADDR) "\0" +# error "Please DO NOT set CONFIG_ETH1ADDR in board configuration!" #endif #ifdef CONFIG_ETH2ADDR - "eth2addr=" __stringify(CONFIG_ETH2ADDR) "\0" +# error "Please DO NOT set CONFIG_ETH2ADDR in board configuration!" #endif #ifdef CONFIG_ETH3ADDR - "eth3addr=" __stringify(CONFIG_ETH3ADDR) "\0" +# error "Please DO NOT set CONFIG_ETH3ADDR in board configuration!" #endif #ifdef CONFIG_ETH4ADDR - "eth4addr=" __stringify(CONFIG_ETH4ADDR) "\0" +# error "Please DO NOT set CONFIG_ETH4ADDR in board configuration!" #endif #ifdef CONFIG_ETH5ADDR - "eth5addr=" __stringify(CONFIG_ETH5ADDR) "\0" +# error "Please DO NOT set CONFIG_ETH5ADDR in board configuration!" #endif #ifdef CONFIG_ETHPRIME "ethprime=" CONFIG_ETHPRIME "\0" #endif #ifdef CONFIG_IPADDR - "ipaddr=" __stringify(CONFIG_IPADDR) "\0" +# error "Please DO NOT set CONFIG_IPADDR in board configuration!" #endif #ifdef CONFIG_SERVERIP "serverip=" __stringify(CONFIG_SERVERIP) "\0" @@ -86,10 +86,10 @@ const uchar default_environment[] = { "rootpath=" CONFIG_ROOTPATH "\0" #endif #ifdef CONFIG_GATEWAYIP - "gatewayip=" __stringify(CONFIG_GATEWAYIP) "\0" +# error "Please DO NOT set CONFIG_GATEWAYIP in board configuration!" #endif #ifdef CONFIG_NETMASK - "netmask=" __stringify(CONFIG_NETMASK) "\0" +# error "Please DO NOT set CONFIG_NETMASK in board configuration!" #endif #ifdef CONFIG_HOSTNAME "hostname=" __stringify(CONFIG_HOSTNAME) "\0" -- 1.8.5.3