From: Ian Jackson Subject: [PATCH 2/2] xl: Comment error handling in dolog Date: Wed, 19 Feb 2014 14:03:30 +0000 Message-ID: <1392818610-30007-2-git-send-email-ian.jackson@eu.citrix.com> References: <21252.47381.304145.583259@mariner.uk.xensource.com> <1392818610-30007-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392818610-30007-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: Ian Jackson , Ian Campbell , coverity@xenproject.org List-Id: xen-devel@lists.xenproject.org Coverity-ID: 1087116 Signed-off-by: Ian Jackson CC: Ian Campbell CC: coverity@xenproject.org --- tools/libxl/xl_cmdimpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 4fc46eb..1a7fd09 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -352,6 +352,8 @@ static void dolog(const char *file, int line, const char *func, char *fmt, ...) rc = vasprintf(&s, fmt, ap); va_end(ap); if (rc >= 0) + /* we ignore write errors since we have no way to report them; + * the alternative would be to abort the whole program */ libxl_write_exactly(NULL, logfile, s, rc, NULL, NULL); free(s); } -- 1.7.10.4