Received: from eggs.gnu.org ([2001:4830:134:3::10]:38422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HCj-0002tY-NY for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:16:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1HCg-00005L-Db for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:16:33 -0500 Received: from mx5-phx2.redhat.com ([209.132.183.37]:42455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1HCg-00005E-6Y for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:16:30 -0500 Date: Tue, 24 Nov 2015 12:16:25 -0500 (EST) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1392859900.16565560.1448385385696.JavaMail.zimbra@redhat.com> In-Reply-To: <1448384789-14830-4-git-send-email-armbru@redhat.com> References: <1448384789-14830-1-git-send-email-armbru@redhat.com> <1448384789-14830-4-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.5 3/5] tests/ivshmem-test: Supply missing initializer in get_device() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre lureau , claudio fontana , qemu-devel@nongnu.org ----- Original Message ----- > If the device isn't found, the assertion uses dev without > initialization. Fix that. >=20 > Signed-off-by: Markus Armbruster my bad :) Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > tests/ivshmem-test.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/tests/ivshmem-test.c b/tests/ivshmem-test.c > index f1793ba..8f1a849 100644 > --- a/tests/ivshmem-test.c > +++ b/tests/ivshmem-test.c > @@ -40,6 +40,7 @@ static QPCIDevice *get_device(void) > QPCIBus *pcibus; > =20 > pcibus =3D qpci_init_pc(); > + dev =3D NULL; > qpci_device_foreach(pcibus, 0x1af4, 0x1110, save_fn, &dev); > g_assert(dev !=3D NULL); > =20 > -- > 2.4.3 >=20 >=20