Received: from eggs.gnu.org ([2001:4830:134:3::10]:37793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGtB5-00047m-Oq for qemu-devel@nongnu.org; Fri, 21 Feb 2014 11:42:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGtAz-0002kO-Nf for qemu-devel@nongnu.org; Fri, 21 Feb 2014 11:42:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGtAz-0002kC-FH for qemu-devel@nongnu.org; Fri, 21 Feb 2014 11:42:13 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1LGgCrW006660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Feb 2014 11:42:12 -0500 From: Markus Armbruster Date: Fri, 21 Feb 2014 17:42:05 +0100 Message-Id: <1393000925-8446-3-git-send-email-armbru@redhat.com> In-Reply-To: <1393000925-8446-1-git-send-email-armbru@redhat.com> References: <1393000925-8446-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] pci-assign: Fix potential read beyond buffer on -EBUSY List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com readlink() doesn't write a terminating null byte. assign_failed_examine() passes the unterminated string to strrchr(). Oops. Terminate it. Spotted by Coverity. Signed-off-by: Markus Armbruster --- hw/i386/kvm/pci-assign.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index 9686801..a825871 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -743,6 +743,7 @@ static void assign_failed_examine(AssignedDevice *dev) goto fail; } + driver[r] = 0; ns = strrchr(driver, '/'); if (!ns) { goto fail; -- 1.8.1.4