From: Jan Kara Subject: [PATCH 2/4] writeback: Move removal from writeback list in evict() Date: Thu, 20 Mar 2014 15:30:54 +0100 Message-ID: <1395325856-8171-3-git-send-email-jack@suse.cz> References: <1395325856-8171-1-git-send-email-jack@suse.cz> Cc: Wu Fengguang , Andrew Morton , dchinner@redhat.com, Jan Kara To: linux-fsdevel@vger.kernel.org Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53226 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756610AbaCTOb1 (ORCPT ); Thu, 20 Mar 2014 10:31:27 -0400 In-Reply-To: <1395325856-8171-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Remove inode from writeback list only after waiting for flusher work do be done with it (I_SYNC is cleared). Currently it makes no difference but later we will depend on the fact that while inode has I_SYNC set, it is pinned in the dirty writeback list. Signed-off-by: Jan Kara --- fs/inode.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 4bcdad3c9361..11e2c4b58803 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -532,9 +532,6 @@ static void evict(struct inode *inode) BUG_ON(!(inode->i_state & I_FREEING)); BUG_ON(!list_empty(&inode->i_lru)); - if (!list_empty(&inode->i_wb_list)) - inode_wb_list_del(inode); - inode_sb_list_del(inode); /* @@ -544,6 +541,8 @@ static void evict(struct inode *inode) * the inode. We just have to wait for running writeback to finish. */ inode_wait_for_writeback(inode); + if (!list_empty(&inode->i_wb_list)) + inode_wb_list_del(inode); if (op->evict_inode) { op->evict_inode(inode); -- 1.8.1.4