Received: from eggs.gnu.org ([2001:4830:134:3::10]:33130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WReiX-0001zX-Aa for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:29:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WReiJ-0003lP-TI for qemu-devel@nongnu.org; Sun, 23 Mar 2014 05:29:21 -0400 From: Prasad Joshi Date: Sun, 23 Mar 2014 14:58:38 +0530 Message-Id: <1395566923-5074-1-git-send-email-prasadjoshi.linux@gmail.com> Subject: [Qemu-devel] [PATCH 1/6] audio: set top level latch for each slot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: prasadjoshi.linux@gmail.com Cc: peter.maydell@linaro.org, stefanha@redhat.com, v.maffione@gmail.com, aik@ozlabs.ru, jan.kiszka@siemens.com, riku.voipio@iki.fi, agraf@suse.de, chouteau@adacore.com, qemu-devel@nongnu.org, qemu-trivial@nongnu.org, av1474@comtv.ru, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, g.lettieri@iet.unipi.it, alex@alex.org.uk, rizzo@iet.unipi.it, afaerber@suse.de CSMKeyControll function is supposed to set the top level latch for each slot. However, at the moment, it incorrectly updates only the first slot. Patch fixes the problem. Signed-off-by: Prasad Joshi --- hw/audio/fmopl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 290a224..eb60c12 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -725,7 +725,7 @@ INLINE void CSMKeyControll(OPL_CH *CH) OPL_KEYOFF(slot2); /* total level latch */ slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl); - slot1->TLL = slot1->TL + (CH->ksl_base>>slot1->ksl); + slot2->TLL = slot2->TL + (CH->ksl_base>>slot2->ksl); /* key on */ CH->op1_out[0] = CH->op1_out[1] = 0; OPL_KEYON(slot1); -- 1.8.1.2