From: "Gupta, Sourab" Subject: Re: [PATCH v5] drm/i915/vlv: Added a rendering specific Hw WA 'WaTlbInvalidateStoreDataBefore' Date: Tue, 25 Mar 2014 09:39:12 +0000 Message-ID: <1395740389.19358.100.camel@sourabgu-desktop> References: <20140324184717.GT4366@nuc-i3427.alporthouse.com> <1395736265-20419-1-git-send-email-sourab.gupta@intel.com> <20140325091512.GZ4366@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 50CEF6E0C5 for ; Tue, 25 Mar 2014 02:40:31 -0700 (PDT) In-Reply-To: <20140325091512.GZ4366@nuc-i3427.alporthouse.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , "intel-gfx@lists.freedesktop.org" , "Goel, Akash" List-Id: intel-gfx@lists.freedesktop.org On Tue, 2014-03-25 at 09:15 +0000, Chris Wilson wrote: > On Tue, Mar 25, 2014 at 02:01:05PM +0530, sourab.gupta@intel.com wrote: > > From: Akash Goel > > > > Added a new rendering specific Workaround 'WaTlbInvalidateStoreDataBefore'. > > This workaround has to be applied before doing TLB Invalidation. > > In this WA, before pipecontrol with TLB invalidate set, need to add 2 MI > > Store data commands. > > Without this, hardware cannot guarantee the command after the PIPE_CONTROL > > with TLB inv will not use the old TLB values. > > > > v2: Modified the WA comment (Ville) > > > > v3: Added the vlv identifier with WA name (Damien) > > > > v4: Reworked based on Chris' comments (WA moved to gen7 ring flush func, > > sending 6 dwords instead of 8) (Chris) > > > > v5: Enhancing the scope of WA to gen6, gen7. Having a common WA func being > > called from gen6, gen7 flush functions. (Ville) > > > > @@ -1733,6 +1771,13 @@ static int gen6_bsd_ring_flush(struct intel_ring_buffer *ring, > > uint32_t cmd; > > int ret; > > > > + /* Apply WaTlbInvalidateStoreDataBefore workaround */ > > + if (invalidate) { > > + ret = gen6_tlb_invalidate_wa(ring); > > + if (ret) > > + return ret; > > + } > > BSD uses MI_FLUSH_DW. Does this w/a still apply? Do we need it for BLT > as well? VEBOX? > -Chris > This should be applicable only to the render ring funcs, not the bsd, blt, vebox ones, as you called out. PIPE_CONTROL is used only in render ring, others use MI_FLUSH. My bad for missing this out. Thanks, Sourab