From: =?UTF-8?q?Andreas=20Bie=C3=9Fmann?= Date: Thu, 10 Apr 2014 12:52:50 +0200 Subject: [U-Boot] [PATCH 1/3] board:tricorder: always work with valid eeprom data In-Reply-To: <1397127172-12917-1-git-send-email-andreas.devel@googlemail.com> References: <1397127172-12917-1-git-send-email-andreas.devel@googlemail.com> Message-ID: <1397127172-12917-2-git-send-email-andreas.devel@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de From: Andreas Bie?mann Commit 890880583d84607e36b52a785a96b167728bbf73 introduced EEPROM parsing and board detection but faild to return a valid tricorder_eeprom struct for backup case. When pressing S200 while reading EEPROM we ignore the value. We returned falsely a tricorder_eeprom struct with uninitialized data which is just garbage. Initialize it by zeroing the whole structure. Signed-off-by: Andreas Bie?mann Cc: Thomas Weber Signed-off-by: Andreas Bie?mann --- board/corscience/tricorder/tricorder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/corscience/tricorder/tricorder.c b/board/corscience/tricorder/tricorder.c index 2dfcb27..9e81bf3 100644 --- a/board/corscience/tricorder/tricorder.c +++ b/board/corscience/tricorder/tricorder.c @@ -79,6 +79,8 @@ static void get_eeprom(struct tricorder_eeprom *eeprom) } else { panic("Could not get board revision\n"); } + } else { + memset(eeprom, 0, TRICORDER_EEPROM_SIZE); } } -- 1.7.10.4