From: Hin-Tak Leung Subject: finderInfo of the Spotlight directory files. Date: Mon, 14 Apr 2014 10:01:32 +0100 (BST) Message-ID: <1397466092.56933.YahooMailBasic@web172303.mail.ir2.yahoo.com> Reply-To: htl10@users.sourceforge.net Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Cc: linux-fsdevel@vger.kernel.org To: slava@dubeyko.com Return-path: Received: from nm20-vm1.bullet.mail.ir2.yahoo.com ([212.82.96.243]:48550 "EHLO nm20-vm1.bullet.mail.ir2.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbaDNJBe convert rfc822-to-8bit (ORCPT ); Mon, 14 Apr 2014 05:01:34 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Vyacheslav, I have a few files which don't seem to have valid finderinfo data: /mnt/.Spotlight-V100/.journalHistoryLog /mnt/.Spotlight-V100/.store.db /mnt/.Spotlight-V100/_rules.plist /mnt/.Spotlight-V100/ContentIndex.db /mnt/.Spotlight-V100/store.db But since they are spotlight files, and the spotlight directory is special (it is filtered from fsevent in xnu). Also they don't have meaningful finderinfo anyway, since they aren't created by user nor used by any applications. The failure is near "if (found_bit >= (len*8)) res = 0;" in attr.c - I am thinking of just doing this, to accept entirely empty ones: diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c index 6c0aef0..941a4aa 100644 --- a/fs/hfsplus/xattr.c +++ b/fs/hfsplus/xattr.c @@ -777,7 +777,6 @@ ssize_t hfsplus_listxattr(struct dentry *dentry, char *buffer, size_t size) if (err) { if (err == -ENOENT) { if (res == 0) - res = -ENODATA; goto end_listxattr; } else { res = err; I am not sure why you have the "if (found_bit >= (len*8))" check - although not having any meaningful finderinfo is strange, but a fair number of files/directories are special and/or invisible to finder, so it is legitimate not to have them? Hin-Tak