Message-ID: <1398789310.16672.440.camel@ted>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Christopher Larson <kergoth@gmail.com>
Date: Tue, 29 Apr 2014 17:35:10 +0100
In-Reply-To: <1398698854-15713-1-git-send-email-kergoth@gmail.com>
References: <1398698854-15713-1-git-send-email-kergoth@gmail.com>
Mime-Version: 1.0
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] codeparser: don't interact with the cache for subshells
Precedence: list
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Mon, 2014-04-28 at 08:27 -0700, Christopher Larson wrote:
> Doing so was causing leakage between the execs of the main value and that of
> the subshell value, and was causing the cached subshell value to be used for
> the overall variable. At the least this could cause execs contamination
> between two variables that while differing, run the same subshell. Beyond
> that, it's possible we could have been using an incomplete cached value of
> a subshell for that of the main value.
> 
> Before this, bb_codeparser.dat would change between parses with differing
> bbfile parse order. After, it does not change.
> 
> The codeparser cache version is bumped, to ensure we don't use potentially
> incorrect cached values from previous runs.
> 
> This should hopefully resolve the difficult-to-reproduce issues we've seen at
> Mentor Graphics where bitbake emits a script to run a task and misses
> dependent functions, resulting in 'command not found' failures. This issue has
> also been mentioned on the oe devel list, where someone hit a case where
> oe_runmake was missing from a do_install task (IIRC). Adding debug information
> showed that bitbake's information about the variable dependencies for this
> task is inaccurate in the failure cases.
> 
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
> ---
>  lib/bb/codeparser.py | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)

That is nasty bug, nicely found!

Cheers,

Richard