From: Dave Gordon Subject: Re: [PATCH v4 2/6] drm/i915/huc: Unified css_header struct for GuC and HuC Date: Thu, 11 Aug 2016 12:03:14 +0100 Message-ID: <13c4ad42-cf0c-57fe-d2e2-4b6663decfa7@intel.com> References: <1470298617-25848-1-git-send-email-peter.antoine@intel.com> <1470298617-25848-3-git-send-email-peter.antoine@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 23B186E8AB for ; Thu, 11 Aug 2016 11:03:16 +0000 (UTC) In-Reply-To: <1470298617-25848-3-git-send-email-peter.antoine@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Peter Antoine , intel-gfx@lists.freedesktop.org Cc: Alex Dai List-Id: intel-gfx@lists.freedesktop.org T24gMDQvMDgvMTYgMDk6MTYsIFBldGVyIEFudG9pbmUgd3JvdGU6Cj4gSHVDIGZpcm13YXJlIGNz cyBoZWFkZXIgaGFzIGFsbW9zdCBleGFjdGx5IHNhbWUgZGVmaW5pdGlvbiBhcyBHdUMKPiBmaXJt d2FyZSBleGNlcHQgZm9yIHRoZSBzd192ZXJzaW9uLiBBbHNvLCBhZGQgYSBuZXcgbWVtYmVyIGZ3 X3R5cGUKPiBpbnRvIGludGVsX3VjX2Z3IHRvIGluZGljYXRlIHdoYXQga2luZCBvZiBmdyBpdCBp cy4gU28sIHRoZSBsb2FkZXIKPiB3aWxsIHB1bGwgcmlnaHQgc3dfdmVyc2lvbiBmcm9tIGhlYWRl ci4KPgo+IHYyOiByZWJhc2VkIG9uLXRvcCBvZiBkcm0taW50ZWwtbmlnaHRseQo+IHYzOiByZWJh c2VkIG9uLXRvcCBvZiBkcm0taW50ZWwtbmlnaHRseSAoYWdhaW4pLgo+Cj4gU2lnbmVkLW9mZi1i eTogQWxleCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUGV0ZXIgQW50 b2luZSA8cGV0ZXIuYW50b2luZUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Yy5oICAgICAgICB8ICA0ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX2Z3aWYuaCAgIHwgMTYgKysrKysrKysrKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgfCA0MCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiAgMyBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaCBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gaW5kZXggMDJhZGNmYy4uZWJmOWM4ZCAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4gQEAgLTk3LDYgKzk3LDkgQEAgZW51bSBp bnRlbF91Y19md19zdGF0dXMgewo+ICAJVUNfRklSTVdBUkVfU1VDQ0VTUwo+ICB9Owo+Cj4gKyNk ZWZpbmUgVUNfRldfVFlQRV9HVUMJCTAKPiArI2RlZmluZSBVQ19GV19UWVBFX0hVQwkJMQo+ICsK PiAgLyoKPiAgICogVGhpcyBzdHJ1Y3R1cmUgZW5jYXBzdWxhdGVzIGFsbCB0aGUgZGF0YSBuZWVk ZWQgZHVyaW5nIHRoZSBwcm9jZXNzCj4gICAqIG9mIGZldGNoaW5nLCBjYWNoaW5nLCBhbmQgbG9h ZGluZyB0aGUgZmlybXdhcmUgaW1hZ2UgaW50byB0aGUgR3VDLgo+IEBAIC0xMTQsNiArMTE3LDcg QEAgc3RydWN0IGludGVsX3VjX2Z3IHsKPiAgCXVpbnQxNl90IG1ham9yX3Zlcl9mb3VuZDsKPiAg CXVpbnQxNl90IG1pbm9yX3Zlcl9mb3VuZDsKPgo+ICsJdWludDMyX3QgZndfdHlwZTsKPiAgCXVp bnQzMl90IGhlYWRlcl9zaXplOwo+ICAJdWludDMyX3QgaGVhZGVyX29mZnNldDsKPiAgCXVpbnQz Ml90IHJzYV9zaXplOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9n dWNfZndpZi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2Z3aWYuaAo+IGluZGV4 IDk0NDc4NmQuLmE2OWVlMzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZ3VjX2Z3aWYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19md2lm LmgKPiBAQCAtMTU0LDcgKzE1NCw3IEBACj4gICAqIFRoZSBHdUMgZmlybXdhcmUgbGF5b3V0IGxv b2tzIGxpa2UgdGhpczoKPiAgICoKPiAgICogICAgICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tKwo+IC0gKiAgICAgfCAgICAgICAgZ3VjX2Nzc19oZWFkZXIgICAgICAgICB8Cj4gKyAq ICAgICB8ICAgICAgICAgdWNfY3NzX2hlYWRlciAgICAgICAgIHwKPiAgICogICAgIHwgY29udGFp bnMgbWFqb3IvbWlub3IgdmVyc2lvbiAgfAo+ICAgKiAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0rCj4gICAqICAgICB8ICAgICAgICAgICAgIHVDb2RlICAgICAgICAgICAgIHwK PiBAQCAtMTgwLDkgKzE4MCwxNiBAQAo+ICAgKiAzLiBMZW5ndGggaW5mbyBvZiBlYWNoIGNvbXBv bmVudCBjYW4gYmUgZm91bmQgaW4gaGVhZGVyLCBpbiBkd29yZHMuCj4gICAqIDQuIE1vZHVsdXMg YW5kIGV4cG9uZW50IGtleSBhcmUgbm90IHJlcXVpcmVkIGJ5IGRyaXZlci4gVGhleSBtYXkgbm90 IGFwcGVhcgo+ICAgKiBpbiBmdy4gU28gZHJpdmVyIHdpbGwgbG9hZCBhIHRydW5jYXRlZCBmaXJt d2FyZSBpbiB0aGlzIGNhc2UuCj4gKyAqCj4gKyAqIEh1QyBmaXJtd2FyZSBsYXlvdXQgaXMgc2Ft ZSBhcyBHdUMgZmlybXdhcmUuCj4gKyAqCj4gKyAqIEh1QyBmaXJtd2FyZSBjc3MgaGVhZGVyIGlz IGRpZmZlcmVudC4gSG93ZXZlciwgdGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB3aGVyZQo+ICsgKiB0 aGUgdmVyc2lvbiBpbmZvcm1hdGlvbiBpcyBzYXZlZC4gVGhlIHVjX2Nzc19oZWFkZXIgaXMgdW5p ZmllZCB0byBzdXBwb3J0Cj4gKyAqIGJvdGguIERyaXZlciBzaG91bGQgZ2V0IEh1QyB2ZXJzaW9u IGZyb20gdWNfY3NzX2hlYWRlci5odWNfc3dfdmVyc2lvbiwgd2hpbGUKPiArICogdWNfY3NzX2hl YWRlci5ndWNfc3dfdmVyc2lvbiBmb3IgR3VDLgo+ICAgKi8KPgo+IC1zdHJ1Y3QgZ3VjX2Nzc19o ZWFkZXIgewo+ICtzdHJ1Y3QgdWNfY3NzX2hlYWRlciB7Cj4gIAl1aW50MzJfdCBtb2R1bGVfdHlw ZTsKPiAgCS8qIGhlYWRlcl9zaXplIGluY2x1ZGVzIGFsbCBub24tdUNvZGUgYml0cywgaW5jbHVk aW5nIGNzc19oZWFkZXIsIHJzYQo+ICAJICoga2V5LCBtb2R1bHVzIGtleSBhbmQgZXhwb25lbnQg ZGF0YS4gKi8KPiBAQCAtMjEzLDcgKzIyMCwxMCBAQCBzdHJ1Y3QgZ3VjX2Nzc19oZWFkZXIgewo+ Cj4gIAljaGFyIHVzZXJuYW1lWzhdOwo+ICAJY2hhciBidWlsZG51bWJlclsxMl07Cj4gLQl1aW50 MzJfdCBkZXZpY2VfaWQ7Cj4gKwl1bmlvbiB7Cj4gKwkJdWludDMyX3QgZGV2aWNlX2lkOwo+ICsJ CXVpbnQzMl90IGh1Y19zd192ZXJzaW9uOwo+ICsJfTsKPiAgCXVpbnQzMl90IGd1Y19zd192ZXJz aW9uOwo+ICAJdWludDMyX3QgcHJvZF9wcmVwcm9kX2Z3Owo+ICAJdWludDMyX3QgcmVzZXJ2ZWRb MTJdOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVy LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBpbmRleCAyNWM5 YTkxLi5kMjQ4Y2NkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2FkZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIu Ywo+IEBAIC01NTUsNyArNTU1LDcgQEAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJt X2RldmljZSAqZGV2LCBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3KQo+ICB7Cj4gIAlzdHJ1Y3Qg ZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+ICAJY29uc3Qgc3RydWN0IGZpcm13YXJlICpmdzsK PiAtCXN0cnVjdCBndWNfY3NzX2hlYWRlciAqY3NzOwo+ICsJc3RydWN0IHVjX2Nzc19oZWFkZXIg KmNzczsKPiAgCXNpemVfdCBzaXplOwo+ICAJaW50IGVycjsKPgo+IEBAIC01NzIsMTkgKzU3Miwx OSBAQCB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVj dCBpbnRlbF91Y19mdyAqdWNfZncpCj4gIAkJdWNfZnctPnVjX2Z3X3BhdGgsIGZ3KTsKPgo+ICAJ LyogQ2hlY2sgdGhlIHNpemUgb2YgdGhlIGJsb2IgYmVmb3JlIGV4YW1pbmluZyBidWZmZXIgY29u dGVudHMgKi8KPiAtCWlmIChmdy0+c2l6ZSA8IHNpemVvZihzdHJ1Y3QgZ3VjX2Nzc19oZWFkZXIp KSB7Cj4gKwlpZiAoZnctPnNpemUgPCBzaXplb2Yoc3RydWN0IHVjX2Nzc19oZWFkZXIpKSB7Cj4g IAkJRFJNX0VSUk9SKCJGaXJtd2FyZSBoZWFkZXIgaXMgbWlzc2luZ1xuIik7Cj4gIAkJZ290byBm YWlsOwo+ICAJfQo+Cj4gLQljc3MgPSAoc3RydWN0IGd1Y19jc3NfaGVhZGVyICopZnctPmRhdGE7 Cj4gKwljc3MgPSAoc3RydWN0IHVjX2Nzc19oZWFkZXIgKilmdy0+ZGF0YTsKPgo+ICAJLyogRmly bXdhcmUgYml0cyBhbHdheXMgc3RhcnQgZnJvbSBoZWFkZXIgKi8KPiAgCXVjX2Z3LT5oZWFkZXJf b2Zmc2V0ID0gMDsKPiAgCXVjX2Z3LT5oZWFkZXJfc2l6ZSA9IChjc3MtPmhlYWRlcl9zaXplX2R3 IC0gY3NzLT5tb2R1bHVzX3NpemVfZHcgLQo+ICAJCWNzcy0+a2V5X3NpemVfZHcgLSBjc3MtPmV4 cG9uZW50X3NpemVfZHcpICogc2l6ZW9mKHUzMik7Cj4KPiAtCWlmICh1Y19mdy0+aGVhZGVyX3Np emUgIT0gc2l6ZW9mKHN0cnVjdCBndWNfY3NzX2hlYWRlcikpIHsKPiArCWlmICh1Y19mdy0+aGVh ZGVyX3NpemUgIT0gc2l6ZW9mKHN0cnVjdCB1Y19jc3NfaGVhZGVyKSkgewo+ICAJCURSTV9FUlJP UigiQ1NTIGhlYWRlciBkZWZpbml0aW9uIG1pc21hdGNoXG4iKTsKPiAgCQlnb3RvIGZhaWw7Cj4g IAl9Cj4gQEAgLTYwOCwyMSArNjA4LDM1IEBAIHZvaWQgaW50ZWxfdWNfZndfZmV0Y2goc3RydWN0 IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdykKPiAgCQlnb3RvIGZh aWw7Cj4gIAl9Cj4KPiAtCS8qIEhlYWRlciBhbmQgdUNvZGUgd2lsbCBiZSBsb2FkZWQgdG8gV09Q Q00uIFNpemUgb2YgdGhlIHR3by4gKi8KPiAtCXNpemUgPSB1Y19mdy0+aGVhZGVyX3NpemUgKyB1 Y19mdy0+dWNvZGVfc2l6ZTsKPiAtCWlmIChzaXplID4gZ3VjX3dvcGNtX3NpemUodG9faTkxNShk ZXYpKSkgewo+IC0JCURSTV9FUlJPUigiRmlybXdhcmUgaXMgdG9vIGxhcmdlIHRvIGZpdCBpbiBX T1BDTVxuIik7Cj4gLQkJZ290byBmYWlsOwo+IC0JfQo+IC0KPiAgCS8qCj4gIAkgKiBUaGUgR3VD IGZpcm13YXJlIGltYWdlIGhhcyB0aGUgdmVyc2lvbiBudW1iZXIgZW1iZWRkZWQgYXQgYSB3ZWxs LWtub3duCj4gIAkgKiBvZmZzZXQgd2l0aGluIHRoZSBmaXJtd2FyZSBibG9iOyBub3RlIHRoYXQg bWFqb3IgLyBtaW5vciB2ZXJzaW9uIGFyZQo+ICAJICogVFdPIGJ5dGVzIGVhY2ggKGkuZS4gdTE2 KSwgYWx0aG91Z2ggYWxsIHBvaW50ZXJzIGFuZCBvZmZzZXRzIGFyZSBkZWZpbmVkCj4gIAkgKiBp biB0ZXJtcyBvZiBieXRlcyAodTgpLgo+ICAJICovCj4gLQl1Y19mdy0+bWFqb3JfdmVyX2ZvdW5k ID0gY3NzLT5ndWNfc3dfdmVyc2lvbiA+PiAxNjsKPiAtCXVjX2Z3LT5taW5vcl92ZXJfZm91bmQg PSBjc3MtPmd1Y19zd192ZXJzaW9uICYgMHhGRkZGOwo+ICsJc3dpdGNoICh1Y19mdy0+ZndfdHlw ZSkgewo+ICsJY2FzZSBVQ19GV19UWVBFX0dVQzoKPiArCQkvKiBIZWFkZXIgYW5kIHVDb2RlIHdp bGwgYmUgbG9hZGVkIHRvIFdPUENNLiBTaXplIG9mIHRoZSB0d28uICovCj4gKwkJc2l6ZSA9IHVj X2Z3LT5oZWFkZXJfc2l6ZSArIHVjX2Z3LT51Y29kZV9zaXplOwo+ICsKPiArCQkvKiBUb3AgMzJr IG9mIFdPUENNIGlzIHJlc2VydmVkICg4SyBzdGFjayArIDI0ayBSQzYgY29udGV4dCkuICovCj4g KwkJaWYgKHNpemUgPiBndWNfd29wY21fc2l6ZSh0b19pOTE1KGRldikpKSB7Cj4gKwkJCURSTV9F UlJPUigiRmlybXdhcmUgaXMgdG9vIGxhcmdlIHRvIGZpdCBpbiBXT1BDTVxuIik7Cj4gKwkJCWdv dG8gZmFpbDsKPiArCQl9Cj4gKwo+ICsJCXVjX2Z3LT5tYWpvcl92ZXJfZm91bmQgPSBjc3MtPmd1 Y19zd192ZXJzaW9uID4+IDE2Owo+ICsJCXVjX2Z3LT5taW5vcl92ZXJfZm91bmQgPSBjc3MtPmd1 Y19zd192ZXJzaW9uICYgMHhGRkZGOwo+ICsJCWJyZWFrOwoKUHJlZmVyIGEgYmxhbmsgbGluZSBh ZnRlciBicmVhazsKCj4gKwljYXNlIFVDX0ZXX1RZUEVfSFVDOgo+ICsJCXVjX2Z3LT5tYWpvcl92 ZXJfZm91bmQgPSBjc3MtPmh1Y19zd192ZXJzaW9uID4+IDE2Owo+ICsJCXVjX2Z3LT5taW5vcl92 ZXJfZm91bmQgPSBjc3MtPmh1Y19zd192ZXJzaW9uICYgMHhGRkZGOwo+ICsJCWJyZWFrOwoKYW5k IGhlcmUuCgo+ICsJZGVmYXVsdDoKPiArCQlEUk1fRVJST1IoIlVua25vd24gZmlybXdhcmUgdHlw ZSAlZFxuIiwgdWNfZnctPmZ3X3R5cGUpOwo+ICsJCWVyciA9IC1FTk9FWEVDOwo+ICsJCWdvdG8g ZmFpbDsKPiArCX0KPgo+ICAJaWYgKHVjX2Z3LT5tYWpvcl92ZXJfZm91bmQgIT0gdWNfZnctPm1h am9yX3Zlcl93YW50ZWQgfHwKPiAgCSAgICB1Y19mdy0+bWlub3JfdmVyX2ZvdW5kIDwgdWNfZnct Pm1pbm9yX3Zlcl93YW50ZWQpIHsKCk5vIG90aGVyIHByb2JsZW1zIGZvdW5kLCBzbwoKUmV2aWV3 ZWQtYnk6IERhdmUgR29yZG9uIDxkYXZpZC5zLmdvcmRvbkBpbnRlbC5jb20+CgpldmVuIHdpdGhv dXQgdGhlIGV4dHJhIGJsYW5rIGxpbmVzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==