Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D99A7CD3436 for ; Fri, 8 May 2026 14:40:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wLMMi-0001sT-Fr; Fri, 08 May 2026 10:39:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLMMb-0001rJ-Ec for qemu-arm@nongnu.org; Fri, 08 May 2026 10:39:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wLMMY-0007cK-RN for qemu-arm@nongnu.org; Fri, 08 May 2026 10:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778251173; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IPdghPq+tdyEmOuhyPSK5nQ1AdYqLmrQ28ER9Z/2XHI=; b=Smdevbjz6e5/JCxD5sWiV8B9d5+y2eXC54FkJT5a13DxNRONMz88wMt0OO3ztnNj02QhAx b8UgKswr9WbgFAltp339lbWBvDRmfLgXBGrtCquCKiPZIm0c6V+l/AyOFsOwlYdD381iNT LIDnj8BAqNFYgAdNgWQbZLhAOy6gHgs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-rJYe0-lDPaK-wnV3WkxZ1Q-1; Fri, 08 May 2026 10:39:32 -0400 X-MC-Unique: rJYe0-lDPaK-wnV3WkxZ1Q-1 X-Mimecast-MFC-AGG-ID: rJYe0-lDPaK-wnV3WkxZ1Q_1778251171 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48d127eb013so12511475e9.1 for ; Fri, 08 May 2026 07:39:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778251171; x=1778855971; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IPdghPq+tdyEmOuhyPSK5nQ1AdYqLmrQ28ER9Z/2XHI=; b=cfvW8arg4CvBPtYlQgoNSkSTCXmSZbeZEJurXoTze4Vs/WZxg9afmUgUPCeaJp4TpD s+As63qpziJ8t3njoUvZ6Fd0CvtUOK2HuOzk9Fy30xkQRrKW1YzxIPPOt+rf+x59bmf4 jzcBv/7ppjwknrPOVSXIkEZFX+rZaQl5nz3D/xC8PtTHae2iCoYoyJricS34256w83+9 LzBTNDHbvX8wl1Ht0aTUslacoSvOQ9DvSSN5WhRWnufgmj+SK6PMlS4B8VuZYJbWYVXb 0i1fiJcvqq6nPEIvE+GrOMD8OoEmk2NRpYF5CMjU4b6fryZRwZzz8IqBtO1++H3C1uEs D1lg== X-Forwarded-Encrypted: i=1; AFNElJ81v89p1gx/AKGm4wSYgoG0cjRNwP2LknqGsx2gPkmy2twaewOUVlsRyYSgGcClmLNoCqJWdD4xaw==@nongnu.org X-Gm-Message-State: AOJu0YyQWKd0SAcO8fa7DizbgK7o2JY6rMm1eNbgn8z48nzAaZb1NRCn yEVAJn1xK0kUcVtTRtzzpT1dtu7oeNP57anF1s4lwvqJMUpGdAf4taCzCcJtuc52hmjVZAOZNyD Oq03zxC8P5O6j09IwA7XeWvt4EK7FTD6EJtvgSBcXzH+izslrG0A9pQ== X-Gm-Gg: AeBDiesMAqO/tf8fItdxUQst65ySnOC5lFX1ga/vWEsXRL5ymxJzohdPC2KCensZK40 wcE8YKn76GOWM/x2ntVMXswOOMWwJKncSDR7YWN7JC8KUFKPS25T62cNZZgrniqj04AVuvu2rd+ ktnHaDXTRYK3b9qNwaih2mZ8qM3IvBJhI/kaj1oI3qGlejNtMOYkvq1woTs99XcVZBaGGw8Agrl lS3ctCz8wXCkToGnBsKUgBwwLqrofJbwFYf5rt+nxEQK9DwxjtJDeRfQO4+rXz1TzekX58ncVGW lacQn22lbmARK4DqYKCD8eiGXAYKsBjigSyAUhLv1fcN/Ili1k1oRUu4rz+/4Cdwejfy9xbdlp8 60sQj72xONyGotlfkbp7V2r+HFWpTEZU09Gm8cKRivo/YxNcOQsPAhUGrEyjZS7L4cS+RsA== X-Received: by 2002:a05:600c:350a:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48e676ac38fmr45837075e9.22.1778251170409; Fri, 08 May 2026 07:39:30 -0700 (PDT) X-Received: by 2002:a05:600c:350a:b0:48a:5565:ec3d with SMTP id 5b1f17b1804b1-48e676ac38fmr45836485e9.22.1778251169904; Fri, 08 May 2026 07:39:29 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454917d57aesm5010794f8f.26.2026.05.08.07.39.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 May 2026 07:39:29 -0700 (PDT) Message-ID: <13ecaca7-9365-4f44-a31d-7fdd0902dbcf@redhat.com> Date: Fri, 8 May 2026 16:39:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 25/31] hw/arm/tegra241-cmdqv: Add reset handler To: Shameer Kolothum Thodi , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" Cc: "peter.maydell@linaro.org" , "clg@redhat.com" , "alex@shazbot.org" , Nicolin Chen , Nathan Chen , Matt Ochs , Jiandi An , Jason Gunthorpe , "jonathan.cameron@huawei.com" , "zhenzhong.duan@intel.com" , Krishnakant Jaju , "phrdina@redhat.com" References: <20260415105552.622421-1-skolothumtho@nvidia.com> <20260415105552.622421-26-skolothumtho@nvidia.com> <667dd47e-bb1a-47d7-bd19-194efade286a@redhat.com> From: Eric Auger In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UZsaVFdkgC9vEg0oIiiiT0BZboT6hsQp_OueitVFgIA_1778251171 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 5/8/26 1:19 PM, Shameer Kolothum Thodi wrote: > >> -----Original Message----- >> From: Eric Auger >> Sent: 07 May 2026 17:52 >> To: Shameer Kolothum Thodi ; qemu- >> arm@nongnu.org; qemu-devel@nongnu.org >> Cc: peter.maydell@linaro.org; clg@redhat.com; alex@shazbot.org; Nicolin >> Chen ; Nathan Chen ; Matt >> Ochs ; Jiandi An ; Jason Gunthorpe >> ; jonathan.cameron@huawei.com; >> zhenzhong.duan@intel.com; Krishnakant Jaju ; >> phrdina@redhat.com >> Subject: Re: [PATCH v4 25/31] hw/arm/tegra241-cmdqv: Add reset handler >> >> External email: Use caution opening links or attachments >> >> >> On 4/15/26 12:55 PM, Shameer Kolothum wrote: >>> From: Nicolin Chen >>> >>> Introduce a reset handler for the Tegra241 CMDQV and initialize its >>> register state. >>> >>> Signed-off-by: Nicolin Chen >>> Signed-off-by: Shameer Kolothum >>> --- >>> hw/arm/tegra241-cmdqv.h | 2 ++ >>> hw/arm/tegra241-cmdqv.c | 50 >> +++++++++++++++++++++++++++++++++++++++++ >>> hw/arm/trace-events | 1 + >>> 3 files changed, 53 insertions(+) >>> >>> diff --git a/hw/arm/tegra241-cmdqv.h b/hw/arm/tegra241-cmdqv.h >>> index 2befa6205e..b2a444daef 100644 >>> --- a/hw/arm/tegra241-cmdqv.h >>> +++ b/hw/arm/tegra241-cmdqv.h >>> @@ -79,6 +79,8 @@ FIELD(CONFIG, CMDQ_MAX_CLK_BATCH, 4, 8) >>> FIELD(CONFIG, CMDQ_MAX_CMD_BATCH, 12, 8) >>> FIELD(CONFIG, CONS_DRAM_EN, 20, 1) >>> >>> +#define V_CONFIG_RESET 0x00020403 >>> + >>> REG32(PARAM, 0x4) >>> FIELD(PARAM, CMDQV_VER, 0, 4) >>> FIELD(PARAM, CMDQV_NUM_CMDQ_LOG2, 4, 4) >>> diff --git a/hw/arm/tegra241-cmdqv.c b/hw/arm/tegra241-cmdqv.c >>> index 9c2fc02b92..af68add2f0 100644 >>> --- a/hw/arm/tegra241-cmdqv.c >>> +++ b/hw/arm/tegra241-cmdqv.c >>> @@ -8,6 +8,7 @@ >>> */ >>> >>> #include "qemu/osdep.h" >>> +#include "qemu/error-report.h" >>> #include "qemu/log.h" >>> >>> #include "hw/arm/smmuv3.h" >>> @@ -645,8 +646,57 @@ free_viommu: >>> return false; >>> } >>> >>> +static void tegra241_cmdqv_init_regs(SMMUv3State *s, Tegra241CMDQV >> *cmdqv) >>> +{ >>> + int i; >>> + >>> + cmdqv->config = V_CONFIG_RESET; >>> + cmdqv->param = FIELD_DP32(0, PARAM, CMDQV_VER, CMDQV_VER); >> hw/core/registerfields.h:#define FIELD_DP32(storage, reg, field, val) >> what does this 0? > I think it is to make sure we have no garbage set for non-field bits. > Starting from 0 guarantees non-field bits are clean. OK thanks ;-) Eric > >>> + cmdqv->param = FIELD_DP32(cmdqv->param, PARAM, >> CMDQV_NUM_CMDQ_LOG2, >>> + CMDQV_NUM_CMDQ_LOG2); >> I was a bit puzzled by the FIELD name being the value name but well. >>> + cmdqv->param = FIELD_DP32(cmdqv->param, PARAM, >> CMDQV_NUM_SID_PER_VI_LOG2, >>> + CMDQV_NUM_SID_PER_VI_LOG2); >>> + trace_tegra241_cmdqv_init_regs(cmdqv->param); >>> + cmdqv->status = R_STATUS_CMDQV_ENABLED_MASK; >>> + for (i = 0; i < 2; i++) { >>> + cmdqv->vi_err_map[i] = 0; >>> + cmdqv->vi_int_mask[i] = 0; >>> + cmdqv->cmdq_err_map[i] = 0; >>> + } >>> + cmdqv->cmdq_err_map[2] = 0; >>> + cmdqv->cmdq_err_map[3] = 0; >> the split looks pretty strange, ie. loop of 2 + continue with individual >> setting. why don't you do the init of >> >> cmdqv->cmdq_err_map in the x4 loop below > 😊. True, that does look strange. I will change. > > Thanks, > Shameer