From: "ordex (Code Review)" Date: Wed, 2 Apr 2025 13:50:58 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <13f140cbb14dd3ee2a994ff97b45743d51ad9a7b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="9RQYGtFOsKQ="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use SSL_get0_peer_signature_name instead of SSL_get_peer_signature_nid List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , openvpn-devel --9RQYGtFOsKQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/927?usp=3Demail ) Change subject: Use SSL_get0_peer_signature_name instead of SSL_get_peer_si= gnature_nid ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Patchset: PS4: patch makes sense and does what it says. Our openssl-ifdef-foomble-moomble is already a bit out of control and nothi= ng this patch can do about... File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/927/comment/648cca6f_9030f9dc : PS4, Line 2462: const char *signame =3D NULL; > No. [=E2=80=A6] Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/927?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72ac042be46cad6 Gerrit-Change-Number: 927 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 02 Apr 2025 13:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos Comment-In-Reply-To: ordex Gerrit-MessageType: comment --9RQYGtFOsKQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 4:Code-Review +2=

Vi= ew Change

2 comments:

  • Patchset:

    • Patch Set #4:

      patch makes sense and does what it says.
      O= ur openssl-ifdef-foomble-moomble is already a bit out of control and nothin= g this patch can do about...

  • File src/openvpn/ssl_openssl.c:

    • Patch Set #4, Line 2462: const char *signame =3D NULL;

      <= blockquote style=3D"border-left: 1px solid #aaa; margin: 10px 0; padding: 0= 10px;">No. [=E2=80=A6]

      Acknowledged

To view, vis= it change= 927. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2bc782ceebcc91a8dc8ada0bb72= ac042be46cad6
Gerrit-Change-Number: 927
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 02 Apr 2025 13:50:58= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
Comment-In-Reply-To: ordex <antonio@...2787...= ...>
Gerrit-MessageType: comment
--9RQYGtFOsKQ=--