From: "flichtenheld (Code Review)" Date: Wed, 20 Dec 2023 12:25:20 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <13f8273b20f29cca3bebac77f127435b4c5cc7c6-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Uz0wu8g+mXs="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Use mingw compile definition also to unit tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Uz0wu8g+mXs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/469?usp=3Demail ) Change subject: Use mingw compile definition also to unit tests ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/469/comment/b9f47f2d_bf7caf2c : PS3, Line 293: target_compile_options(${target} PRIVATE -municode -= UUNICODE) combining -municode with -UUNICODE and main(void) just means the -municode = has no effect at all. So I would drop that. http://gerrit.openvpn.net/c/openvpn/+/469/comment/38857a3b_fc89aeff : PS3, Line 666: target_compile_definitions(${test_name} PRIVATE = -Dmain=3Dwmain) Yeah, just don't use -municode in the first place. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/469?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie5aa643ab6190262f7c8b9e614bedb398e85859b Gerrit-Change-Number: 469 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Wed, 20 Dec 2023 12:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Uz0wu8g+mXs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 3:Code-Review -1=

Vi= ew Change

2 comments:

  • File CMakeLists.txt:

    • Patch Set #3, Line 293: <= code style=3D"font-family:monospace,monospace"> target_compile_optio= ns(${target} PRIVATE -municode -UUNICODE)

      combining -municode with -UUNICODE and = main(void) just means the -municode has no effect at all. So I would drop t= hat.

    • Patch Set #3, Line 666: target_compile_definitions(${test_name} = PRIVATE -Dmain=3Dwmain)

      Yeah, just don't use -municode in the first place.

To view, visit change 469. To unsubscribe, or for help w= riting mail filters, visit s= ettings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie5aa643ab6190262f7c8b9e614b= edb398e85859b
Gerrit-Change-Number: 469
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Wed, 20 Dec 2023 12:25:20= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--Uz0wu8g+mXs=--