Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD193C43219 for ; Tue, 8 Nov 2022 14:23:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 57F6084F83; Tue, 8 Nov 2022 15:23:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="nxpGOxxb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D9DC484FB5; Tue, 8 Nov 2022 15:23:24 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9C64E84F81 for ; Tue, 8 Nov 2022 15:23:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x832.google.com with SMTP id z6so8715540qtv.5 for ; Tue, 08 Nov 2022 06:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hbIsu2OsCvBbIM/I/5Zet29UO9rkOhvwz7zngkLtJxs=; b=nxpGOxxb9P0Uq96vuqugPw/G7AUdXuuyVWJtS+MVdmMzmhkjynNHTPHMgvOjAeN4rK UqmmGgafg6OWtgPvWyRjbOb7stimvqmTY4k7s+75nrSmN1cwUx4SO01LwU4UGuN7V0Xk pv9DjP4MpjnDxlg6EAMP3f1Zy12kwXPLvhzcyJZ3QjqnfkaDS6o+zzS5eBKpmx4thL+H EbcYNreu9jMDYwjLxlKdnTrn/y3EQVmxCs3K0tNtl1e6G3XmzpIqUGNpJtBpnxqzQqRA YlFbC1zNGDEpu16j6viEW/z4wGOSAew/2uxtlOYOXcqIHzwRRJMrm1QQjEXm3UWbeS3k LFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hbIsu2OsCvBbIM/I/5Zet29UO9rkOhvwz7zngkLtJxs=; b=RvI6gKUG02jaz5cjO/cjnXGbIITR4YEviIxKwyEIDM6zCVsy4/6V4WHBB1dRg88dbk 3zVEZbiNIynuXN26mJWDc4OJACWkA0IcJYiBRr3qhfRjs9ssfPCN6UmhM0O47CpgEJ5f 4XxVzYX94U5u6UJCyXrjRnlY86zdLNw/KFXHLVo0BS0aKsIpENoQ724c/DBriH/lHHGL g/GuFLLmJLaEyDbooWFm6AMHfq7xIclKK3SlNpHtHEOZjZW8xX/+oiWWzZu5qziM5zTj xVSAiaq+LU1/48ykCeSQemy5Dy6zohOJfp4CpFligwOQwtzPrxbqoA+wFrp8q4KJBXZv JppQ== X-Gm-Message-State: ANoB5pkpPsy7vEtVkK9cucgHWT1UUQN3qmfR/3WEei1Cp+Tv39T2/tEp ugJDwuvCGf0x329FojMVqlA= X-Google-Smtp-Source: AA0mqf6lPJyYJsWPfcxMjOFiCcECDfyGd7f/maVtiLF8O7FxlCBLFH8UWXBJ4ntiVaRzVC2h1XJzdQ== X-Received: by 2002:ac8:5847:0:b0:3a5:a072:4e0d with SMTP id h7-20020ac85847000000b003a5a0724e0dmr4045002qth.325.1667917400315; Tue, 08 Nov 2022 06:23:20 -0800 (PST) Received: from [192.168.1.201] (pool-173-73-95-180.washdc.fios.verizon.net. [173.73.95.180]) by smtp.gmail.com with ESMTPSA id r16-20020ae9d610000000b006ee7e223bb8sm9157159qkk.39.2022.11.08.06.23.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 06:23:19 -0800 (PST) Message-ID: <13fa1f45-d831-b6c3-df8a-5ed9fc7a2a7c@gmail.com> Date: Tue, 8 Nov 2022 09:23:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Content-Language: en-US To: Conor Dooley , Heinrich Schuchardt Cc: Padmarao Begari , Cyril Jean , u-boot@lists.denx.de References: <20221107095546.28362-1-heinrich.schuchardt@canonical.com> From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 11/8/22 09:16, Conor Dooley wrote: > On Mon, Nov 07, 2022 at 10:55:46AM +0100, Heinrich Schuchardt wrote: >> HSS 2022.10 provides support for resetting the board. > > It's actually v2022.09 that added support for reset. I don't think that > that is important to correct though, since v2022.10 is the version we > are updating the dt in U-Boot to match. > Reviewed-by: Conor Dooley > > One minor & mostly unrelated question below. > >> Signed-off-by: Heinrich Schuchardt >> --- >> configs/microchip_mpfs_icicle_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig >> index c295b9bad3..65bd50db80 100644 >> --- a/configs/microchip_mpfs_icicle_defconfig >> +++ b/configs/microchip_mpfs_icicle_defconfig >> @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000 >> CONFIG_SYS_RELOC_GD_ENV_ADDR=y >> CONFIG_BOOTP_SEND_HOSTNAME=y >> CONFIG_DM_MTD=y >> +CONFIG_SYSRESET=y >> +CONFIG_SYSRESET_SBI=y > > I took a look at the config option, but something seemed odd to me. It > says "depends on SBI_V02" but the help text says "version 0.3". I see > there's no define for SBI_V03 so I assume that's why there's a mismatch. > > I didn't see a comment about it in the commit hence asking. AFAIR, v0.3 > is the correct version. IIRC 0.3 is the same as 0.2 except it was ratified. >> config SYSRESET_SBI >> bool "Enable support for SBI System Reset" >> depends on RISCV_SMODE && SBI_V02 >> default y >> select SYSRESET_CMD_POWEROFF if CMD_POWEROFF >> help >> Enable system reset and poweroff via the SBI system reset extension. >> The extension was introduced in version 0.3 of the SBI specification.