Received: from eggs.gnu.org ([2001:4830:134:3::10]:39969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X4seI-0005kE-TZ for qemu-devel@nongnu.org; Wed, 09 Jul 2014 10:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X4seB-0001kC-Cw for qemu-devel@nongnu.org; Wed, 09 Jul 2014 10:15:06 -0400 From: Kevin Wolf Date: Wed, 9 Jul 2014 16:14:48 +0200 Message-Id: <1404915288-604-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH for-2.1] test-string-output-visitor: Fix unterminated string List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, hutao@cn.fujitsu.com, qemu-trivial@nongnu.org, mst@redhat.com Don't forget to add a terminating '\0' or the test case will be randomly failing. The broken code was added in commit b4900c0e. Signed-off-by: Kevin Wolf --- tests/test-string-output-visitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-string-output-visitor.c b/tests/test-string-output-visitor.c index e89e43c..f2c427f 100644 --- a/tests/test-string-output-visitor.c +++ b/tests/test-string-output-visitor.c @@ -201,11 +201,11 @@ static void test_visitor_out_enum(TestOutputVisitorData *data, visit_type_EnumOne(data->ov, &i, "unused", &err); g_assert(!err); - len = strlen(EnumOne_lookup[i]) + 2; + len = strlen(EnumOne_lookup[i]) + 3; str_human = g_malloc0(len); str_human[0] = '"'; strncpy(str_human + 1, EnumOne_lookup[i], strlen(EnumOne_lookup[i])); - str_human[len - 1] = '"'; + str_human[len - 2] = '"'; str = string_output_get_string(data->sov); g_assert(str != NULL); -- 1.8.3.1