From: "flichtenheld (Code Review)" Date: Mon, 11 Dec 2023 16:09:44 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <140d5cd578b0f7f5151bfa1750871d8eed9fbe8a-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0eZhmj/g3vk="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: test_user_pass: new UT for get_user_pass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --0eZhmj/g3vk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/468?usp=3Demail ) Change subject: test_user_pass: new UT for get_user_pass ...................................................................... Patch Set 3: (1 comment) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/468/comment/3e694e97_351c140e : PS3, Line 625: ENVIRONMENT "srcdir=3D${CMAKE_CURRENT_SOURCE= _DIR}/tests/unit_tests/openvpn") > Alternative solution with the define: https://gerrit.openvpn. [=E2=80=A6] srcdir environment variable is the official interface for automake test sui= te which is why I used it. But we can go for a define as well. Should proba= bly report that as a bug against your IDE though. Just ignoring part of the= cmake code seems bad. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/468?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I193aef06912f01426dd4ac298aadfab97dd75a35 Gerrit-Change-Number: 468 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 11 Dec 2023 16:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos Gerrit-MessageType: comment --0eZhmj/g3vk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File CMakeLists.txt:

    • Patch Set #3, Line 625: ENVIRONMENT "= ;srcdir=3D${CMAKE_CURRENT_SOURCE_DIR}/tests/unit_tests/openvpn")

      Alternative solution with the define: https://gerrit.openv= pn. [=E2=80=A6]

      srcdir environment variable is the official interface for a= utomake test suite which is why I used it. But we can go for a define as we= ll. Should probably report that as a bug against your IDE though. Just igno= ring part of the cmake code seems bad.

To view, v= isit chan= ge 468. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I193aef06912f01426dd4ac298aa= dfab97dd75a35
Gerrit-Change-Number: 468
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Mon, 11 Dec 2023 16:09:44= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <arne-openvp= n@...1227...>
Gerrit-MessageType: comment
--0eZhmj/g3vk=--