From: =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= Subject: [PATCH 1/2] leds: trigger: gpio: fix warning in gpio trigger for gpios whose accessor function may sleep Date: Tue, 9 Sep 2014 09:40:32 +0200 Message-ID: <1410248433-24005-2-git-send-email-LW@KARO-electronics.de> References: <1410248433-24005-1-git-send-email-LW@KARO-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.karo-electronics.de ([81.173.242.67]:56882 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079AbaIIHkl (ORCPT ); Tue, 9 Sep 2014 03:40:41 -0400 In-Reply-To: <1410248433-24005-1-git-send-email-LW@KARO-electronics.de> Sender: linux-leds-owner@vger.kernel.org List-Id: linux-leds@vger.kernel.org To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Richard Purdie , Bryan Wu , =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= When using a GPIO driver whose accessor functions may sleep (e.g. an I2C GPIO extender like PCA9554) the following warning is issued: WARNING: CPU: 0 PID: 665 at drivers/gpio/gpiolib.c:2274 gpiod_get_raw_v= alue+0x3c/0x48() Modules linked in: CPU: 0 PID: 665 Comm: kworker/0:2 Not tainted 3.16.0-karo+ #115 Workqueue: events gpio_trig_work [] (unwind_backtrace) from [] (show_stack+0x10/0x14= ) [] (show_stack) from [] (warn_slowpath_common+0x64/= 0x84) [] (warn_slowpath_common) from [] (warn_slowpath_nu= ll+0x1c/0x24) [] (warn_slowpath_null) from [] (gpiod_get_raw_valu= e+0x3c/0x48) [] (gpiod_get_raw_value) from [] (gpio_trig_work+0x= 1c/0xb0) [] (gpio_trig_work) from [] (process_one_work+0x144= /0x38c) [] (process_one_work) from [] (worker_thread+0x60/0= x5cc) [] (worker_thread) from [] (kthread+0xb4/0xd0) [] (kthread) from [] (ret_from_fork+0x14/0x24) ---[ end trace cd51a1dad8b86c9c ]--- =46ix this by using the _cansleep() variant of gpio_get_value(). Signed-off-by: Lothar Wa=C3=9Fmann --- drivers/leds/trigger/ledtrig-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/trigger/ledtrig-gpio.c b/drivers/leds/trigger= /ledtrig-gpio.c index 35812e3..c86c418 100644 --- a/drivers/leds/trigger/ledtrig-gpio.c +++ b/drivers/leds/trigger/ledtrig-gpio.c @@ -48,7 +48,7 @@ static void gpio_trig_work(struct work_struct *work) if (!gpio_data->gpio) return; =20 - tmp =3D gpio_get_value(gpio_data->gpio); + tmp =3D gpio_get_value_cansleep(gpio_data->gpio); if (gpio_data->inverted) tmp =3D !tmp; =20 --=20 1.7.10.4