From: Ian Campbell Date: Thu, 11 Sep 2014 19:57:18 +0100 Subject: [U-Boot] [PATCH 1/7] ARM: sunxi: Fix build break when CONFIG_USB_EHCI is not defined In-Reply-To: <5411D997.8040801@redhat.com> References: <1410182892-18647-1-git-send-email-wens@csie.org> <1410182892-18647-2-git-send-email-wens@csie.org> <5411D997.8040801@redhat.com> Message-ID: <1410461838.14432.5.camel@dagon.hellion.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2014-09-11 at 19:19 +0200, Hans de Goede wrote: > Hi Chen, > > On 09/11/2014 07:07 PM, Chen-Yu Tsai wrote: > > Hi Ian, Hans, > > > > On Mon, Sep 8, 2014 at 9:28 PM, Chen-Yu Tsai wrote: > >> BOOT_TARGET_DEVICES includes USB unconditionally. This breaks when > >> CONFIG_CMD_USB is not defined. Use a secondary macro to conditionally > >> include it when CONFIG_EHCI is enabled, as we do for CONFIG_AHCI. > > > > The other patches are for the next release, but maybe this fix could > > go into 2014.10? > > I agree that this is a benign bug fix, but since we don't have any > boards not setting CONFIG_EHCI atm I don't really see the value > for getting it into 2014.10. FWIW I was planning on putting the whole series in #next until the next merge window as soon as I find a some spare moments to look through it (sorry, might take me a few more days, I'm travelling at the w/e). Ian.