From: Artem Bityutskiy Subject: Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities Date: Fri, 03 Oct 2014 19:19:28 +0300 Message-ID: <1412353168.10105.5.camel@sauron.fi.intel.com> References: <1412089998-18978-1-git-send-email-tlinder@codeaurora.org> <1412350035.3795.101.camel@sauron.fi.intel.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga11.intel.com ([192.55.52.93]:17689 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753020AbaJCQU4 (ORCPT ); Fri, 3 Oct 2014 12:20:56 -0400 In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Tanya Brokhman , linux-arm-msm@vger.kernel.org, open list , "linux-mtd@lists.infradead.org" , Richard Weinberger , Brian Norris , David Woodhouse On Fri, 2014-10-03 at 17:50 +0200, Rafa=C5=82 Mi=C5=82ecki wrote: > On 3 October 2014 17:27, Artem Bityutskiy wrote= : > > Yes, I guess a single patch is indeed OK. I have few nit-picks, tho= ugh. > > > > On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: > >> - ubi_err("'ubi_io_read_ec_hdr()' returned unknown cod= e %d", err); > >> + ubi_err(ubi, > >> + "'ubi_io_read_ec_hdr()' returned unknown code %d",= err); > >> return -EINVAL; > > > > I think it is fine if the line is long in these cases, let's keep t= he > > message on the same line, this split does not contribute to better > > readability, quite the opposite, in my opinion. > > > > One line: > > ubi_err(ubi, "long line") > > > > Multiple lines: > > ubi_err(ubi, "long line, > > parameters) >=20 > You should discuss that with checkpatch team, because ARAIR it will > complain about "long line" with any other parameter in the same line. I respect checkpatch.pl, and uniformity / consistency, but in this particular case I put my maintainer hat on and say that for this kernel subsystem it is fine, because the maintainer will be more efficient in maintaining this code when the code is a bit mere readable for him. Artem.