From: Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v4] mtd: ubi: Extend UBI layer debug/messaging
 capabilities
Date: Mon, 20 Oct 2014 16:53:13 +0300
Message-ID: <1413813193.7906.295.camel@sauron.fi.intel.com>
References: <1413296037-22346-1-git-send-email-tlinder@codeaurora.org>
	 <20141014143902.GA9768@arch.hh.imgtec.org>
	 <1413299343.7906.103.camel@sauron.fi.intel.com>
	 <20141014184702.GA12662@arch.hh.imgtec.org>
	 <1413314020.26864.7.camel@joe-AO725>
	 <20141014191815.GB12662@arch.hh.imgtec.org>
	 <1413315062.10221.1.camel@joe-AO725>
Reply-To: dedekind1@gmail.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1413315062.10221.1.camel@joe-AO725>
Sender: linux-kernel-owner@vger.kernel.org
To: Joe Perches <joe@perches.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>, Tanya Brokhman <tlinder@codeaurora.org>, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Richard Weinberger <richard@nod.at>, open list <linux-kernel@vger.kernel.org>
List-Id: linux-arm-msm@vger.kernel.org

On Tue, 2014-10-14 at 12:31 -0700, Joe Perches wrote:
> On Tue, 2014-10-14 at 16:18 -0300, Ezequiel Garcia wrote:
> > On 14 Oct 12:13 PM, Joe Perches wrote:
> > > On Tue, 2014-10-14 at 15:47 -0300, Ezequiel Garcia wrote:
> []
> > > > When the gendisk is not available, a simple pr_{} would work.
> > > 
> > > Or maybe combine these in the ubi_<level> calls passing
> > > NULL when there is no struct ubi_device *
> []
> > Isn't this excessive obfuscation? What's the benefit of it?
> 
> Single error message type.

Well, these are 2 separate drivers just living in the same folder, so
they do not have to have to share message functions.

Artem.